path: root/xlators/features/changelog
diff options
authorMichael Adam <>2015-03-30 19:48:27 +0200
committerVenky Shankar <>2015-04-02 05:27:46 -0700
commit41bc3f7f023de198c695bdb7708afef3910cc761 (patch)
tree429a2b1d06462644a67787259e463c48a0c11a60 /xlators/features/changelog
parentdb7b8d6e5d4485fc5a6e836447dfa5d3cb85b5fd (diff)
features/bit-rot: fix CID 1124725 - use after free
Coverity fixes: CID 1124725 CID 1291742 The problem is that gf_tw_cleanup_timers() frees the handed in priv->timer_wheel but it can not set the pointer to NULL, so subsequent checks for priv->timer_wheel show it as not NULL and allow for access after free. The proper change might be to change gf_tw_cleanup_timers() to take a reference to the pointer and set it to NULL after free, but since it is under contrib/, I did not want to change that function. Instead this patch uses the function's return code which was not used previously. (Maybe this should even be done in a wrapper macro or function?) Change-Id: I31d80d3df2e4dc7503d62c7819429e1a388fdfdd BUG: 789278 Signed-off-by: Michael Adam <> Reviewed-on: Tested-by: Gluster Build System <> Reviewed-by: Venky Shankar <> Tested-by: Venky Shankar <>
Diffstat (limited to 'xlators/features/changelog')
0 files changed, 0 insertions, 0 deletions