feature/changelog: Capture path for deletes

PROBLEM:
There is no way to get the path of deleted file if we
have gfid from changelog since the file is already deleted.

SOLUTION:
Do a recursive readlink on parent gfid in backend .glusterfs
path to get the complete path in I/O callpath in changelog
translator and capture it in callback.

The path captured is relative from the brick root. The field
separator used is '\0'.
e.g.,
......\0<pgfid>/bname\0<relative-path>\0<next-record>

ADDITIONAL REQUIRED CHANGES:

1. The changelog translator option called "changelog.capture-del-path"
   is introduced to enable or disable the capturing of deleted entry
   path.
   e.g.,
   gluster vol set <vol-name> changelog.capture-del-path on/off

   If capture-del-path is disabled, '\0' is captured instead of
   relative path.
   e.g.,
   ......\0<pgfid>/bname\0\0\0<next-record>

2. The minor number in the version of changelog is bumped up from v1.1
   to v1.2.

3. If recursive readlink is failed for some reason, it will capture
   \0 in place of <relative path>.
   e.g.,
   ......\0<pgfid>/bname\0\0\0<next-record>
   (same as when caputre-del-path option is disabled)

4. If bname argument passed to "resolve_pargfid_to_path" function
   is NULL and pargfid is ROOT, "." is returned. This is not the
   case with changelog, where bname is always passed. This is
   applicable to other consumers of "resolve_pargfid_to_path"
   routine.

NOTE:
   Changelog parser should consider the above new changes
   and should parse accordingly.

BUG: 1218383
Change-Id: I5d89cf4157befd207771f6c0248d2493fbf85832
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Reviewed-on: http://review.gluster.org/10288
Reviewed-on: http://review.gluster.org/10535
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>

1 files changed, 26 insertions, 0 deletions

diff --git a/xlators/features/changelog/src/changelog-helpers.h b/xlators/features/changelog/src/changelog-helpers.h
index b552c308e0f..ccfbf9113d8 100644
--- a/xlators/features/changelog/src/changelog-helpers.h
+++ b/xlators/features/changelog/src/changelog-helpers.h
@@ -306,6 +306,9 @@ struct changelog_priv {
         pthread_t *ev_dispatcher;
 
         changelog_clnt_t connections;
+
+        /* glusterfind dependency to capture paths on deleted entries*/
+        gf_boolean_t capture_del_path;
 };
 
 struct changelog_local {
@@ -349,6 +352,7 @@ typedef enum {
 struct changelog_entry_fields {
         uuid_t  cef_uuid;
         char   *cef_bname;
+        char   *cef_path;
 };
 
 typedef struct {
@@ -497,6 +501,8 @@ changelog_dispatch_event (xlator_t *, changelog_priv_t *, changelog_event_t *);
 changelog_inode_ctx_t *
 __changelog_inode_ctx_get (xlator_t *, inode_t *, unsigned long **,
                            unsigned long *, changelog_log_type);
+int
+resolve_pargfid_to_path (xlator_t *this, uuid_t gfid, char **path, char *bname);
 
 /* macros */
 
@@ -566,6 +572,26 @@ __changelog_inode_ctx_get (xlator_t *, inode_t *, unsigned long **,
                 xlen += (UUID_CANONICAL_FORM_LEN + strlen (bname));     \
         } while (0)
 
+#define CHANGELOG_FILL_ENTRY_DIR_PATH(co, pargfid, bname, converter,        \
+                                      del_freefn, xlen, label, capture_del) \
+        do {                                                                \
+                co->co_convert = converter;                                 \
+                co->co_free = del_freefn;                                   \
+                co->co_type = CHANGELOG_OPT_REC_ENTRY;                      \
+                gf_uuid_copy (co->co_entry.cef_uuid, pargfid);              \
+                co->co_entry.cef_bname = gf_strdup(bname);                  \
+                if (!co->co_entry.cef_bname)                                \
+                        goto label;                                         \
+                xlen += (UUID_CANONICAL_FORM_LEN + strlen (bname));         \
+                if (!capture_del || resolve_pargfid_to_path (this, pargfid, \
+                    &(co->co_entry.cef_path), co->co_entry.cef_bname)) {    \
+                        co->co_entry.cef_path = gf_strdup ("\0");           \
+                        xlen += 1;                                          \
+                } else {                                                    \
+                        xlen += (strlen (co->co_entry.cef_path));           \
+                }                                                           \
+        } while (0)
+
 #define CHANGELOG_INIT(this, local, inode, gfid, xrec)                  \
         local = changelog_local_init (this, inode, gfid, xrec, _gf_false)