summaryrefslogtreecommitdiffstats
path: root/xlators/features/bit-rot/src/stub/bit-rot-stub.c
diff options
context:
space:
mode:
authorNiels de Vos <ndevos@redhat.com>2015-07-18 12:55:39 +0200
committerNiels de Vos <ndevos@redhat.com>2015-07-24 08:08:24 -0700
commit8a4f0de2a6dc5d1a9cbc54bbe9aa25d7e38d4ae7 (patch)
treefa832968c2076b97e8ae83e1b8e9da3c5a75c6d8 /xlators/features/bit-rot/src/stub/bit-rot-stub.c
parent996926530bc2da34f616d01b8f94c0ed7884aaeb (diff)
dict: merge static/non-static dict_set_* variations
Copy/pasting complete functions for setting one boolean is rather ugly, this can easily be solved with a helper function that gets the boolean as an extra parameter. Also removing dict_set_dynmstr() because there are no callers, and using GF_MALLOC() or GF_CALLOC() to allocate memory for strings is much more preferred. And, as Kaleb pointed out, prefixing functions with an underscore '_' is reserved for libc internals. Renaming the _dict_*() functions for that reason. Change-Id: I8e681954502f17e59c8f5e8a294d3db238d3e5f3 BUG: 1232304 Reported-by: Kaleb KEITHLEY <kkeithle@redhat.com> Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: http://review.gluster.org/11716 Tested-by: Gluster Build System <jenkins@build.gluster.com> Tested-by: NetBSD Build System <jenkins@build.gluster.org> Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Diffstat (limited to 'xlators/features/bit-rot/src/stub/bit-rot-stub.c')
0 files changed, 0 insertions, 0 deletions