path: root/xlators/features/bit-rot/src/bitd/bit-rot.c
diff options
authorPranith Kumar K <>2016-09-23 21:06:37 +0530
committerPranith Kumar Karampuri <>2016-10-17 12:00:28 -0700
commitb5a7dd5b39845d5e58fdd257b5c2bf801c7c1c8a (patch)
treefdd6dc8a36dc3cabcaa5b45431d54c357bf781ed /xlators/features/bit-rot/src/bitd/bit-rot.c
parenta8b2a981881221925bb5edfe7bb65b25ad855c04 (diff)
storage/posix: Fix race in posix_pstat
Problem: When one thread is in the process of creating a file/directory and the other thread is doing readdirp, there is a chance that posix_pstat, creation fops race in the following manner which will lead to wrong stat values to be read by parent xlators like posix-acl. Creation fops posix_pstat() as part of readdirp 1) file is created with uid/gid 0/0 1) does stat of the path that is created just now. 2) Does chown to set the correct uid/gid 3) Sets the acl/user/internal xattrs 4) Sets the gfid on the entry and completes the creation of the file/dir 2) fills the gfid in the iatt If unwind of readdirp hits server xlator before creation fop, then posix-acl remembers uid/gid of the file to be root/root and fails fops like open etc on it. Fix: Reverse the order of filling gfid and filling lstat() values in posix_pstat() so that if there is gfid in iatt buffer uid/gid are valid. Change-Id: I46caa7f6da7abfa40a0b1d70e35b88de9c64959c Signed-off-by: Pranith Kumar K <> Reviewed-on: NetBSD-regression: NetBSD Build System <> CentOS-regression: Gluster Build System <> Smoke: Gluster Build System <> Reviewed-by: Shyamsundar Ranganathan <>
Diffstat (limited to 'xlators/features/bit-rot/src/bitd/bit-rot.c')
0 files changed, 0 insertions, 0 deletions