diff options
| author | Kaleb S. KEITHLEY <kkeithle@redhat.com> | 2017-08-18 11:24:44 -0400 |
|---|---|---|
| committer | Jeff Darcy <jeff@pl.atyp.us> | 2017-08-28 12:47:25 +0000 |
| commit | 553ac4cc6da5c6cbc1e6c6f87dc3cdfd935c0880 (patch) | |
| tree | 0a1bf9d0ca2e57a5e611ecb8f9689c6f743ab521 /xlators/cluster/ec/src/ec-common.h | |
| parent | 2645e730b79b44fc035170657e43bb52f3e855c5 (diff) | |
cluster/ec: coverity, fix for BAD_SHIFT
This is how I would like to see this fixed.
passes (eliminates the warning in) coverity.
The use of uintptr_t as a bitmask is a problem IMO, especially on
32-bit clients.
Change-Id: I86e15d12939c610c99f5f96c551bb870df20f4b4
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Reviewed-on: https://review.gluster.org/18067
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Diffstat (limited to 'xlators/cluster/ec/src/ec-common.h')
| -rw-r--r-- | xlators/cluster/ec/src/ec-common.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/cluster/ec/src/ec-common.h b/xlators/cluster/ec/src/ec-common.h index a03a590402a..0e8be35dbf9 100644 --- a/xlators/cluster/ec/src/ec-common.h +++ b/xlators/cluster/ec/src/ec-common.h @@ -75,7 +75,7 @@ typedef enum { #define EC_STATE_HEAL_DISPATCH 218 gf_boolean_t ec_dispatch_one_retry (ec_fop_data_t *fop, ec_cbk_data_t **cbk); -int32_t ec_dispatch_next(ec_fop_data_t * fop, int32_t idx); +void ec_dispatch_next(ec_fop_data_t * fop, uint32_t idx); void ec_complete(ec_fop_data_t *fop); |