summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/dht/src/dht.c
diff options
context:
space:
mode:
authorKaleb S. KEITHLEY <kkeithle@redhat.com>2018-10-01 14:09:03 -0400
committerShyamsundar Ranganathan <srangana@redhat.com>2018-10-04 14:41:17 +0000
commit4f7729748ee7d79e41dec9682a4fbbb2378ed5ac (patch)
treee4984fb0aa2e6ff95690d83bbba62ea24ebf9c70 /xlators/cluster/dht/src/dht.c
parentdbafe63ea5602db3ad65a3e4fba15b6ee97776ce (diff)
dht: volume_options 'options' collision with nfs-ganesha's 'options'
When dht was converted to xlator_api, the variable 'options' was not changed to dht_options, the same as was done to all the other xlators that were converted to xlator_api. Thus the reference to 'options' in dht.c is not resolved until runtime, and the RTlinker's search path starts with symbols in the executable, i.e. ganesha.nfsd's 'options'. (Which is obviously not the right one.) The unused extern references to 'options' (now dht_options) in nufa.c and switch.c is curious. Change-Id: Idf4a5d5fbd39aadfa5a4b529bceea65a3cbdf8f3 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Diffstat (limited to 'xlators/cluster/dht/src/dht.c')
-rw-r--r--xlators/cluster/dht/src/dht.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/xlators/cluster/dht/src/dht.c b/xlators/cluster/dht/src/dht.c
index 6dfaa3b23ed..63ab926ca58 100644
--- a/xlators/cluster/dht/src/dht.c
+++ b/xlators/cluster/dht/src/dht.c
@@ -104,7 +104,8 @@ struct xlator_cbks cbks = {
extern int32_t
mem_acct_init(xlator_t *this);
-extern struct volume_options options[];
+
+extern struct volume_options dht_options[];
xlator_api_t xlator_api = {
.init = dht_init,
@@ -116,7 +117,7 @@ xlator_api_t xlator_api = {
.dumpops = &dumpops,
.fops = &fops,
.cbks = &cbks,
- .options = options,
+ .options = dht_options,
.identifier = "distribute",
.pass_through_fops = &dht_pt_fops,
.category = GF_MAINTAINED,