summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/dht/src/dht-common.c
diff options
context:
space:
mode:
authorMichael Scherer <misc@redhat.com>2017-02-19 16:16:00 +0100
committerShyamsundar Ranganathan <srangana@redhat.com>2017-02-20 18:32:38 -0500
commit4a1740d3e8fbccc18772c0fc5f70f2cd7443d51e (patch)
treef968e016e6287a8300acf6d90e19192b0e69eef5 /xlators/cluster/dht/src/dht-common.c
parentb4da61c9fc6dd8f800792f0d0db4c5e8e948af4f (diff)
Ressources used by va_start must be freed with va_end
Coverty warn of the defect. Change-Id: Ie86684520e1d5b41237ab8d3247c24564a1a8639 BUG: 1424802 Signed-off-by: Michael Scherer <misc@redhat.com> Reviewed-on: https://review.gluster.org/16673 Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com> Tested-by: Raghavendra G <rgowdapp@redhat.com> Reviewed-by: Susant Palai <spalai@redhat.com> Reviewed-by: Raghavendra G <rgowdapp@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators/cluster/dht/src/dht-common.c')
-rw-r--r--xlators/cluster/dht/src/dht-common.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c
index 447279ecd34..6a061641fd0 100644
--- a/xlators/cluster/dht/src/dht-common.c
+++ b/xlators/cluster/dht/src/dht-common.c
@@ -9038,8 +9038,10 @@ dht_notify (xlator_t *this, int event, void *data, ...)
ret = dict_get_int32 (dict, "rebalance-command",
(int32_t*)&cmd);
- if (ret)
+ if (ret) {
+ va_end (ap);
return ret;
+ }
LOCK (&defrag->lock);
{
if (defrag->is_exiting)
@@ -9064,6 +9066,7 @@ dht_notify (xlator_t *this, int event, void *data, ...)
}
unlock:
UNLOCK (&defrag->lock);
+ va_end (ap);
return ret;
break;
}