diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2014-10-21 16:18:16 +0530 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2014-10-22 00:32:40 -0700 |
| commit | 5fff385333db750561ffd026af09e52a8c8c16e6 (patch) | |
| tree | db77cdee6977a558b2d5401c297d5c0bf5092b9b /xlators/cluster/afr/src | |
| parent | 946eecfff75d7c9f4df3890ce57311386fe6e994 (diff) | |
logs: Do selective logging for errnos
Backport of http://review.gluster.org/8918
http://review.gluster.org/8955
Problem:
Just after replace-brick the mount logs are filled with ENOENT/ESTALE
warning logs because the file is yet to be self-healed now that the
brick is new.
Fix:
Do conditional logging for the logs. ENOENT/ESTALE will be logged at
lower log level. Only when debug logs are enabled, these logs will
be written to the logfile.
BUG: 1155073
Change-Id: Icf06f2fc4f2f91e199de24a88bcb0ce9b8955ebd
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/8960
Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src')
| -rw-r--r-- | xlators/cluster/afr/src/afr-open.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/xlators/cluster/afr/src/afr-open.c b/xlators/cluster/afr/src/afr-open.c index 9404b6e847b..ccfd655eebb 100644 --- a/xlators/cluster/afr/src/afr-open.c +++ b/xlators/cluster/afr/src/afr-open.c @@ -264,9 +264,10 @@ afr_openfd_fix_open_cbk (call_frame_t *frame, void *cookie, xlator_t *this, "successfully on subvolume %s", local->loc.path, priv->children[child_index]->name); } else { - gf_log (this->name, GF_LOG_ERROR, "Failed to open %s " - "on subvolume %s", local->loc.path, - priv->children[child_index]->name); + gf_log (this->name, fop_log_level (GF_FOP_OPEN, op_errno), + "Failed to open %s on subvolume %s [%s]", + local->loc.path, priv->children[child_index]->name, + strerror (op_errno)); } fd_ctx = afr_fd_ctx_get (local->fd, this); |