summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/afr/src/afr.h
diff options
context:
space:
mode:
authorPranith Kumar K <pkarampu@redhat.com>2018-02-28 17:58:31 +0530
committerPranith Kumar K <pkarampu@redhat.com>2018-02-28 18:53:59 +0530
commite7b79c59590c203c65f7ac8548b30d068c232d33 (patch)
tree8831e942399bd33da6cbff53a7e21c9b1fb6202a /xlators/cluster/afr/src/afr.h
parente2766c32631d27519e688ebec48c408b36e3cc79 (diff)
cluster/afr: Fix dict-leak in pre-op
At the time of pre-op, pre_op_xdata is populted with the xattrs we get from the disk and at the time of post-op it gets over-written without unreffing the previous value stored leading to a leak. This is a regression we missed in https://review.gluster.org/#/q/ba149bac92d169ae2256dbc75202dc9e5d06538e BUG: 1550078 Change-Id: I0456f9ad6f77ce6248b747964a037193af3a3da7 Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr.h')
-rw-r--r--xlators/cluster/afr/src/afr.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/cluster/afr/src/afr.h b/xlators/cluster/afr/src/afr.h
index 9f4e34a2afa..fdda295718c 100644
--- a/xlators/cluster/afr/src/afr.h
+++ b/xlators/cluster/afr/src/afr.h
@@ -749,8 +749,8 @@ typedef struct _afr_local {
unsigned char *pre_op;
- /* For arbiter configuration only. */
- dict_t **pre_op_xdata;
+ /* Changelog xattr dict for [f]xattrop*/
+ dict_t **changelog_xdata;
unsigned char *pre_op_sources;
/* @failed_subvols: subvolumes on which a pre-op or a