summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/afr/src/afr-open.c
diff options
context:
space:
mode:
authorPranith Kumar K <pkarampu@redhat.com>2016-08-16 16:04:37 +0530
committerPranith Kumar Karampuri <pkarampu@redhat.com>2016-08-22 13:55:42 -0700
commit413594ed647400f1b39e05d4f1b12ad846e48800 (patch)
treefd7072bc983754156eb66ff2348c7ac99773c9e2 /xlators/cluster/afr/src/afr-open.c
parenteddada59f7ad3cf21463a558a5f62591f4b72c68 (diff)
cluster/afr: Give option to do consistent-io
Problem: When tiering/rebalance does migrations and afr with 2-way replica is in picture, migration can read stale data if the source brick goes down and writes to the destination. After this deletion of the file leads to permanent loss of data after migration. Fix: Rebalance/tiering should migrate only when the data is definitely not stale. So introduce an option in afr called consistent-io which will be enabled in migration daemons. BUG: 1306398 Change-Id: I750f65091cc70a3ed4bf3c12f83d0949af43920a Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> Reviewed-on: http://review.gluster.org/13425 Reviewed-by: Anuradha Talur <atalur@redhat.com> Reviewed-by: Krutika Dhananjay <kdhananj@redhat.com> Smoke: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators/cluster/afr/src/afr-open.c')
-rw-r--r--xlators/cluster/afr/src/afr-open.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/xlators/cluster/afr/src/afr-open.c b/xlators/cluster/afr/src/afr-open.c
index 059d3f9bd71..7a628350c34 100644
--- a/xlators/cluster/afr/src/afr-open.c
+++ b/xlators/cluster/afr/src/afr-open.c
@@ -130,12 +130,16 @@ afr_open (call_frame_t *frame, xlator_t *this, loc_t *loc, int32_t flags,
if (!local)
goto out;
+ local->op = GF_FOP_OPEN;
fd_ctx = afr_fd_ctx_get (fd, this);
if (!fd_ctx) {
op_errno = ENOMEM;
goto out;
}
+ if (!afr_is_consistent_io_possible (local, priv, &op_errno))
+ goto out;
+
local->fd = fd_ref (fd);
local->fd_ctx = fd_ctx;
fd_ctx->flags = flags;