diff options
| author | Ravishankar N <ravishankar@redhat.com> | 2017-11-13 07:03:36 +0530 |
|---|---|---|
| committer | Ravishankar N <ravishankar@redhat.com> | 2017-11-24 03:49:33 +0000 |
| commit | 2559d959df1a5dec10b0b80ba5ac0ec292014d8e (patch) | |
| tree | acf1fa1c0bd1c0e858f97fd2790e82849d4aee44 /xlators/cluster/afr/src/afr-inode-write.c | |
| parent | e19f5c34a5bef2f5d097ee359100c3fd43fd310a (diff) | |
afr: coverity fixes
1.afr_discover_do: COPY_PASTE_ERROR
2.afr_fav_child_reset_sink_xattrs_cbk: REVERSE_INULL
3.afr_fop_lock_proceed: UNUSED_VALUE
4.afr_local_init: CHECKED_RETURN
5.afr_set_split_brain_choice: REVERSE_INULL
6.__afr_inode_write_finalize: FORWARD_NULL
7.afr_refresh_heal_done: REVERSE_INULL
8.afr_xl_op:UNUSED_VALUE
9.afr_changelog_populate_xdata: DEADCODE
10.set_afr_pending_xattrs_option: RESOURCE_LEAK
Note:
RESOURCE_LEAK complaints about afr_fgetxattr_pathinfo_cbk,
afr_getxattr_list_node_uuids_cbk and afr_getxattr_pathinfo_cbk seem to
be false alarms.
Change-Id: Ia4ca1478b5e2922084732d14c1e7b1b03ad5ac45
BUG: 789278
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-inode-write.c')
| -rw-r--r-- | xlators/cluster/afr/src/afr-inode-write.c | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/xlators/cluster/afr/src/afr-inode-write.c b/xlators/cluster/afr/src/afr-inode-write.c index 14114699594..8078f4403c0 100644 --- a/xlators/cluster/afr/src/afr-inode-write.c +++ b/xlators/cluster/afr/src/afr-inode-write.c @@ -47,10 +47,11 @@ __afr_inode_write_finalize (call_frame_t *frame, xlator_t *this) local = frame->local; priv = this->private; + GF_VALIDATE_OR_GOTO (this->name, local->inode, out); /*This code needs to stay till DHT sends fops on linked * inodes*/ - if (local->inode && !inode_is_linked (local->inode)) { + if (!inode_is_linked (local->inode)) { for (i = 0; i < priv->child_count; i++) { if (!local->replies[i].valid) continue; @@ -76,14 +77,15 @@ __afr_inode_write_finalize (call_frame_t *frame, xlator_t *this) } } - if (local->inode) { - if (local->transaction.type == AFR_METADATA_TRANSACTION) - read_subvol = afr_metadata_subvol_get (local->inode, - this, NULL, local->readable, NULL, &args); - else - read_subvol = afr_data_subvol_get (local->inode, this, - NULL, local->readable, NULL, &args); - } + if (local->transaction.type == AFR_METADATA_TRANSACTION) { + read_subvol = afr_metadata_subvol_get (local->inode, this, + NULL, local->readable, + NULL, &args); + } else { + read_subvol = afr_data_subvol_get (local->inode, this, + NULL, local->readable, + NULL, &args); + } local->op_ret = -1; local->op_errno = afr_final_errno (local, priv); @@ -131,6 +133,8 @@ __afr_inode_write_finalize (call_frame_t *frame, xlator_t *this) } afr_set_in_flight_sb_status (this, frame, local->inode); +out: + return; } |