path: root/xlators/cluster/afr/src/afr-common.c
diff options
authorAshish Pandey <>2018-10-18 17:15:58 +0530
committerRavishankar N <>2018-10-24 00:56:17 +0000
commitf73b4476b15f9d6d3dc3c8e20c9742aacd857f9f (patch)
tree947e600c0e48d65817d1d262a4ec22ca79045d5c /xlators/cluster/afr/src/afr-common.c
parentbd4d8b182662e08cccc57efa1616651df448b445 (diff)
cluster/afr : Check for UP bricks before starting heal
Problem: Currently for replica volume, even if only one brick is UP SHD will keep crawling index entries even if it can not heal anything. In thin-arbiter volume which is also a replica 2 volume, this causes inode lock contention which in turn sends upcall to all the clients to release notify locks, even if it can not do anything for healing. This will slow down the client performance and kills the purpose of keeping in memory information about bad brick. Solution: Before starting heal or even crawling, check if sufficient number of children are UP and available to check and heal entries. Change-Id: I011c9da3b37cae275f791affd56b8f1c1ac9255d updates: bz#1640581 Signed-off-by: Ashish Pandey <>
Diffstat (limited to 'xlators/cluster/afr/src/afr-common.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-common.c b/xlators/cluster/afr/src/afr-common.c
index 8d50144..e655999 100644
--- a/xlators/cluster/afr/src/afr-common.c
+++ b/xlators/cluster/afr/src/afr-common.c
@@ -4919,7 +4919,7 @@ find_child_index(xlator_t *this, xlator_t *child)
return i;
-static int
__afr_get_up_children_count(afr_private_t *priv)
int up_children = 0;