path: root/tests/features/fdl.t
diff options
authorAvra Sengupta <>2016-06-23 12:15:22 +0530
committerJeff Darcy <>2016-11-08 11:25:25 -0800
commit3e50e09723e024cd451c5f48a153fef0fe4857c7 (patch)
treede1ef8f66ff17eb2791fb406e122486da8cfe463 /tests/features/fdl.t
parent3e980c5eff495725e7c01793451bc81fd6f94ad5 (diff)
jbr: Sending rollback from failed fop to fdl
In case of a failed fop, the failure is detected by the leader in the jbr-server in two places. First during a quorum check of +ve responses when it receives responses from all the followers. At this point if the fop hasn't been successfully journaled at a quorum of followers (as in there is no merit in trying the fop in the leader as the quorum will never be met), then we fail the fop. Also if this quorum is met, then the fop is tried on the leader, and after the leader completes the fop a quorum check similar to the previous one is done again, this time including the leaders outcome. If quorum is not met, then we fail the fop. In both these cases, when the fop fails we send a -ve ack to the client. With this patch, now we will also send a rollback through a GF_FOP_IPC to all the followers(and also to the leader in the second case of failure). This rollback will contain the index and term number of the fop which failed. This will be recorded in the respective journals of the bricks and will be used to rollback the fop on that brick later. A subsequent write, and it's respective rollback would look something like the following in the journal. The trusted.jbr.term and trusted.jbr.index present in the dict of both the logs, relate them, and the presence of "rollback-fop" in the dict of IPC indicates that it is a rollback fop, and the value 13(stands for GF_FOP_WRITE) indicates what kind of rollback operation it is. === GF_FOP_WRITE fd = <gfid 77f12ea2-ca56-40e3-a46e-ba2308baa035> vector = <158 bytes> offset = 0 (0x0) flags = 32769 (0x8001) xdata = dict { trusted.jbr.term = 0 <2 bytes> trusted.jbr.index = 4 <2 bytes> } === GF_FOP_IPC xdata = dict { trusted.jbr.term = 0 <2 bytes> trusted.jbr.index = 4 <2 bytes> rollback-fop = 13 <3 bytes> } Change-Id: I70b6a143d20697153d58e2f719e34ecd1ed160a5 BUG: 1349385 Signed-off-by: Avra Sengupta <> Reviewed-on: NetBSD-regression: NetBSD Build System <> CentOS-regression: Gluster Build System <> Reviewed-by: Jeff Darcy <> Smoke: Gluster Build System <>
Diffstat (limited to 'tests/features/fdl.t')
1 files changed, 1 insertions, 11 deletions
diff --git a/tests/features/fdl.t b/tests/features/fdl.t
index 34d6d78..28097a1 100644
--- a/tests/features/fdl.t
+++ b/tests/features/fdl.t
@@ -2,17 +2,7 @@
. $(dirname $0)/../include.rc
. $(dirname $0)/../volume.rc
-log_base=$($CLI --print-logdir)
-log_id=${log_id:1} # Remove initial slash
-log_id=${log_id//\//-} # Replace remaining slashes with dashes
-check_logfile() {
- [ $(gf_logdump $FDL_META_FILE $FDL_DATA_FILE | grep $1 | wc -l) -ge $2 ]
+. $(dirname $0)/../fdl.rc
if [ x"$OSTYPE" = x"NetBSD" ]; then