summaryrefslogtreecommitdiffstats
path: root/run-tests.sh
diff options
context:
space:
mode:
authorRaghavendra Talur <rtalur@redhat.com>2017-04-04 20:28:07 +0530
committerRaghavendra Talur <rtalur@redhat.com>2017-04-24 15:32:14 +0000
commite37d546042a73bec85fe2ebd0146b88b7079bc66 (patch)
tree4feac3e45af2a1bd53772abf037dfaf8007bf1f1 /run-tests.sh
parente91cdf4d63893c3cc5506f8fd73f00dc47272dc6 (diff)
explicitly specify executor to be bash for tests
We use prove command to run tests. Sometimes tests fail rather strangely with error as shown below: Not a perl script at ./tests/bugs/core/bug-1111557.t line 1. ./tests/bugs/core/bug-1111557.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run https://build.gluster.org/job/centos6-regression/3818/consoleFull https://build.gluster.org/job/centos6-regression/3819/consoleFull https://build.gluster.org/job/centos6-regression/3801/consoleFull Quote from man page `` "--exec" Normally you can just pass a list of Perl tests and the harness will know how to execute them. However, if your tests are not written in Perl or if you want all tests invoked exactly the same way, use the "-e", or "--exec" switch: prove --exec '/usr/bin/ruby -w' t/ ``` Hence, better to comply with recommended practice although it might not be the reason for this failure. > BUG: 1438858 > Signed-off-by: Raghavendra Talur <rtalur@redhat.com> > Reviewed-on: https://review.gluster.org/16996 > Smoke: Gluster Build System <jenkins@build.gluster.org> > Reviewed-by: N Balachandran <nbalacha@redhat.com> > NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> > Reviewed-by: Nigel Babu <nigelb@redhat.com> > CentOS-regression: Gluster Build System <jenkins@build.gluster.org> > Reviewed-by: Jeff Darcy <jeff@pl.atyp.us> (cherry picked from commit d6b88e9b8b02813620c3c1a2ea49d58d29062b3e) Change-Id: If7a0baf20698f8497ef3e8fc422fa67063a4651f BUG: 1444773 Signed-off-by: Raghavendra Talur <rtalur@redhat.com> Reviewed-on: https://review.gluster.org/17103 Tested-by: N Balachandran <nbalacha@redhat.com> Smoke: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'run-tests.sh')
-rwxr-xr-xrun-tests.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/run-tests.sh b/run-tests.sh
index a922f2e2ad1..558256eef62 100755
--- a/run-tests.sh
+++ b/run-tests.sh
@@ -268,7 +268,7 @@ function run_tests()
total_run_tests=$((total_run_tests+1))
echo "[$(date +%H:%M:%S)] Running tests in file $t"
starttime="$(date +%s)"
- prove -vf $t
+ prove -vfe '/bin/bash' $t
TMP_RES=$?
ELAPSEDTIMEMAP[$t]=`expr $(date +%s) - $starttime`
if [ ${TMP_RES} -ne 0 ] && [ "x${retry}" = "xyes" ] ; then
@@ -280,7 +280,7 @@ function run_tests()
echo " * we got some spurous failures *"
echo " *********************************"
echo ""
- prove -vf $t
+ prove -vfe '/bin/bash' $t
TMP_RES=$?
fi
if [ ${TMP_RES} -ne 0 ] ; then