path: root/
diff options
authorPranith Kumar K <>2015-11-10 09:06:54 +0530
committerXavier Hernandez <>2015-11-11 05:48:02 -0800
commit9a69ad2c8438b9fbdcb133404a5d205f809bbb5a (patch)
tree63cea0a2eb5df48133b7f16681b65aee16af2a83 /
parentd025d954a5c593ccb0838788e165c36cb3537b25 (diff)
cluster/ec: fix bug in update_good
Problem: Bricks that didn't participate in the fops are considered to be good. This is happening two fold. Examples: Case-1: 1) 2+1 volume. 'd1' directory on Brick-0 is bad. 2) readdir takes locks and lock->good_mask is '7' 3) readdir does xattrop and fop->mask is '6'. 4) because fop->expected is '1' lock->good_mask remains '7' Case-2: 1) when all the bricks are up, it does lock + xattrop before op and figures out all the bricks are good. 2) By the time second operation starts brick-0 is down. Now lock->good_mask will always have the '0' bit set as long as the operations are happening on it. because: "lock->good_mask &= ~fop->mask | fop->remaining" fop->mask doesn't have '0' th bit. 3) When it comes time to perform the final xattrop in update_size_version brick-0 comes online because of which it gives the same version to brick-0 as well thinking it has participated in all the transactions till then, even when it didn't participate in the transactions. Fix: Case-1's fix: Update lock->good_mask in ec_prepare_update_cbk with latest good/bad bricks Case-2's fix: Consider non-participating brick as bad. Change-Id: Ic01a733f8180131ded6a3cc784fcb1960758cf23 BUG: 1276989 Signed-off-by: Pranith Kumar K <> Reviewed-on: Tested-by: NetBSD Build System <> Tested-by: Gluster Build System <> Reviewed-by: Xavier Hernandez <>
Diffstat (limited to '')
1 files changed, 0 insertions, 1 deletions
diff --git a/ b/
index f94f86c..0d764a4 100755
--- a/
+++ b/
@@ -205,7 +205,6 @@ function is_bad_test ()
./tests/geo-rep/georep-basic-dr-rsync.t \
./tests/geo-rep/georep-basic-dr-tarssh.t \
./tests/bugs/replicate/bug-1221481-allow-fops-on-dir-split-brain.t \
- ./tests/basic/ec/ec-readdir.t \
; do
[ x"$name" = x"$bt" ] && return 0 # bash: zero means true/success