|author||Kotresh HR <email@example.com>||2015-04-24 17:31:03 +0530|
|committer||Vijay Bellur <firstname.lastname@example.org>||2015-05-05 06:29:20 -0700|
rpc: Maintain separate xlator pointer in 'rpcsvc_state'
The structure 'rpcsvc_state', which maintains rpc server state had no separate pointer to track the translator. It was using the mydata pointer itself. So callers were forced to send xlator pointer as mydata which is opaque (void pointer) by function prototype. 'rpcsvc_register_init' is setting svc->mydata with xlator pointer. 'rpcsvc_register_notify' is overwriting svc->mydata with mydata pointer. And rpc interprets svc->mydata as xlator pointer internally. If someone passes non xlator structure pointer to rpcsvc_register_notify as libgfchangelog currently does, it might corrupt mydata. So interpreting opaque mydata as xlator pointer is incorrect as it is caller's choice to send mydata as any type of data to 'rpcsvc_register_notify'. Maintaining two different pointers in 'rpcsvc_state' for xlator and mydata solves the issue. BUG: 1218381 Change-Id: I4c28937a30845e3f41b6fc7a09036149c816659b Signed-off-by: Kotresh HR <email@example.com> Reviewed-on: http://review.gluster.org/10366 Reviewed-on: http://review.gluster.org/10534 Tested-by: Gluster Build System <firstname.lastname@example.org> Tested-by: NetBSD Build System Reviewed-by: Aravinda VK <email@example.com> Reviewed-by: Vijay Bellur <firstname.lastname@example.org>
Diffstat (limited to 'run-tests.sh')
0 files changed, 0 insertions, 0 deletions