path: root/
diff options
authorPranith Kumar K <>2015-05-13 16:57:49 +0530
committerPranith Kumar Karampuri <>2015-05-28 04:12:06 -0700
commit3a57ca8ee29ea8e3d3c5bbf28a56a821bfa99d99 (patch)
tree7e919238192422d4bb1f8a86a950013b286b41b3 /
parent2b8fdde926532014f19d850b1321a4c7046dc001 (diff)
cluster/ec: Fix all EIO errors in EC
Backport of Backport of Backport of Backport of Backport of - When a blocking lock is requested, lock request is succeeded even when ec->fragment number of locks are acquired successfully in non-blocking locking phase. This will lead to fop succeeding only on the bricks where the locks are acquired, leading to the necessity of self-heals. To prevent these un-necessary self-heals, if the remaining locks fail with EAGAIN in non-blocking lock phase try blocking locking phase instead. - Handle lookup failures while op in progress - cluster/ec: Correctly cleanup delayed locks When a delayed lock is pending, a graph switch doesn't correctly terminate it. This means that the update of version and size xattrs is lost, causing EIO errors. This patch handles GF_EVENT_PARENT_DOWN event to correctly finish pending udpdates before completing the graph switch. - Fix use after free crash ec_heal creates ec_fop_data but doesn't run ec_manager. ec_fop_data_allocate adds this fop to ec->pending_fops, because ec_manager is not run on this heal fop it is never removed from ec->pending_fops. When it is accessed after free it leads to crash. It is better to not to add HEAL fops to ec->pending_fops because we don't want graph switch to hang the mount because of a BIG file/directory heal. - Forced unlock when lock contention is detected EC uses an eager lock mechanism to optimize multiple read/write requests on the same entry or inode. This increases performance but can have adverse results when other clients try to access the same entry/inode. To solve this, this patch adds a functionality to detect when this happens and force an earlier release to not block other clients. The method consists on requesting GF_GLUSTERFS_INODELK_COUNT and GF_GLUSTERFS_ENTRYLK_COUNT for all fops that take a lock. When this count is greater than one, the lock is marked to be released. All fops already waiting for this lock will be executed normally before releasing the lock, but new requests that also require it will be blocked and restarted after the lock has been released and reacquired again. Another problem was that some operations did correctly lock the parent of an entry when needed, but got the size and version xattrs from the entry instead of the parent. This patch solves this problem by binding all queries of size and version to each lock and replacing all entrylk calls by inodelk ones to remove concurrent updates on directory metadata. This also allows rename to correctly update source and destination directories. BUG: 1225279 Change-Id: I02a6084b138dd38e018a462347cd9ce38610c7ef Reviewed-on: Tested-by: NetBSD Build System Tested-by: Gluster Build System <> Reviewed-by: Pranith Kumar Karampuri <>
Diffstat (limited to '')
1 files changed, 0 insertions, 6 deletions
diff --git a/ b/
index 0bfa5c6..ef6568c 100755
--- a/
+++ b/
@@ -201,13 +201,7 @@ function is_bad_test ()
./tests/basic/ec/quota.t \
./tests/bugs/distribute/bug-1161156.t \
./tests/basic/tier/tier.t \
- ./tests/basic/ec/ec-4-1.t \
- ./tests/basic/ec/ec.t \
./tests/basic/quota-nfs.t \
- ./tests/basic/ec/ec-6-2.t \
- ./tests/basic/ec/ec-3-1.t \
- ./tests/basic/ec/ec-5-1.t \
- ./tests/basic/ec/ec-12-4.t \
./tests/bugs/quota/bug-1035576.t \
./tests/bugs/glusterfs/bug-867253.t \
./tests/bugs/glusterd/bug-974007.t \