path: root/
diff options
authorAvra Sengupta <>2015-05-22 18:38:23 +0530
committerVijay Bellur <>2015-05-27 08:38:53 -0700
commit0bcd638b46a7134f0285b39aabfed9950645bdc3 (patch)
tree54f585e0f0e48eee0b4ecad16100aa4ae031d2c6 /
parent7a001525850fc60d24be019e4fba726d3c33ee5e (diff)
glusterd: Fix conf->generation to stop new peers participating in
a transaction, while the transaction is in progress. Backport of Every peer gets a generation number, during it's inception. This generation number is used to identify the peer throiughout it's lifetime. This number is assigned based on the current generation number of the system, which is incremented with every peer that is added. The problem arises when we add a peer, and before it gets a rpc_connect we begin a transaction. In such a case, the peer gets considered in the transaction, but doesn't participate in it coz it isn't connected yet. The moment it gets the rpc notification and is connected, it starts participating in the transaction and all hell breaks loose. To resolve it, we should assign the peerinfo a new generation number everytime it's connected, so that this number will be greater than the generation number that the transaction is acting upon, and even though the peer is connected it will not participate in the transaction. We should also assign the new generation number of the peer to the peerctx, so that the framework that searches for peerinfos based on the generation number, will still function in the same manner. Removing ./tests/basic/volume-snapshot-clone.t from bad-tests. Also removed the duplicate entry of ./tests/bugs/snapshot/bug-1112559.t from bad-tests. Original entry was removed in Change-Id: I57e5efe3217abfb96733e487aea3972e116d909d BUG: 1224292 Signed-off-by: Avra Sengupta <> Reviewed-on: Reviewed-by: Kaushal M <> Tested-by: Kaushal M <> Reviewed-on: Reviewed-by: Atin Mukherjee <> Tested-by: Gluster Build System <> Tested-by: NetBSD Build System Reviewed-by: Vijay Bellur <>
Diffstat (limited to '')
1 files changed, 1 insertions, 5 deletions
diff --git a/ b/
index 2d1191a..7a41dcf 100755
--- a/
+++ b/
@@ -194,8 +194,7 @@ function run_tests()
function is_bad_test ()
local name=$1
- for bt in ./tests/basic/volume-snapshot-clone.t \
- ./tests/basic/uss.t \
+ for bt in ./tests/basic/uss.t \
./tests/bugs/replicate/bug-976800.t \
./tests/bugs/replicate/bug-1015990.t \
./tests/bugs/quota/bug-1038598.t \
@@ -211,12 +210,9 @@ function is_bad_test ()
./tests/basic/ec/ec-5-1.t \
./tests/basic/ec/ec-12-4.t \
./tests/bugs/quota/bug-1035576.t \
- ./tests/basic/uss.t \
./tests/bugs/glusterfs/bug-867253.t \
./tests/bugs/glusterd/bug-974007.t \
- ./tests/basic/volume-snapshot-clone.t \
./tests/basic/quota-anon-fd-nfs.t \
- ./tests/bugs/snapshot/bug-1112559.t \
./tests/bugs/disperse/bug-1187474.t \
./tests/basic/afr/sparse-file-self-heal.t \
./tests/basic/afr/data-self-heal.t \