summaryrefslogtreecommitdiffstats
path: root/rpc
diff options
context:
space:
mode:
authorAmar Tumballi <amar@gluster.com>2010-10-04 11:01:14 +0000
committerVijay Bellur <vijay@dev.gluster.com>2010-10-04 09:48:47 -0700
commitbde5cb81e251032594e2bba57fb4a72c10e32207 (patch)
treeead19da09126011c7581f5ac99d5e6ed94a92efa /rpc
parent98d51842863d52bab2674258c3ec12d668139539 (diff)
rpc: don't refer to 'req' after calling 'prog->actor()'
there are chances that a error reply is sent to client from actor, in which case, 'req' would be free'd and accessing it would result in error. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1790 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1790
Diffstat (limited to 'rpc')
-rw-r--r--rpc/rpc-lib/src/rpcsvc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/rpc/rpc-lib/src/rpcsvc.c b/rpc/rpc-lib/src/rpcsvc.c
index 4926b379633..ccb191a17f9 100644
--- a/rpc/rpc-lib/src/rpcsvc.c
+++ b/rpc/rpc-lib/src/rpcsvc.c
@@ -994,7 +994,7 @@ rpcsvc_handle_rpc_call (rpcsvc_t *svc, rpc_transport_t *trans,
}
err_reply:
- if ((ret == RPCSVC_ACTOR_ERROR) || (req->rpc_err != SUCCESS)) {
+ if (ret == RPCSVC_ACTOR_ERROR) {
ret = rpcsvc_error_reply (req);
}