summaryrefslogtreecommitdiffstats
path: root/rpc/rpc-lib/src/rpcsvc-auth.c
diff options
context:
space:
mode:
authorMilind Changire <mchangir@redhat.com>2017-11-22 17:03:11 +0530
committerRaghavendra G <rgowdapp@redhat.com>2017-11-22 16:58:39 +0000
commit50a480701f4bf6885d3811e245a47d99661695d8 (patch)
treec3e4fb52830734fa3c2da0ac2edd93886941d3f8 /rpc/rpc-lib/src/rpcsvc-auth.c
parent8d53be68d8fb4272f0c88fef0a00dad452b941de (diff)
rpc-lib: coverity fixes
Scan URL: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/ ID: 9 (BAD_SHIFT) ID: 58 (CHECKED_RETURN) ID: 98 (DEAD_CODE) ID: 249, 250, 251, 252 (MIXED_ENUMS) ID: 289, 297 (NULL_RETURNS) ID: 609, 613, 622, 644, 653, 655 (UNUSED_VALUE) ID: 432 (RESOURCE_LEAK) Change-Id: I2349877214dd38b789e08b74be05539f09b751b9 BUG: 789278 Signed-off-by: Milind Changire <mchangir@redhat.com>
Diffstat (limited to 'rpc/rpc-lib/src/rpcsvc-auth.c')
-rw-r--r--rpc/rpc-lib/src/rpcsvc-auth.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/rpc/rpc-lib/src/rpcsvc-auth.c b/rpc/rpc-lib/src/rpcsvc-auth.c
index b7d6c2216ef..bfff0bc557f 100644
--- a/rpc/rpc-lib/src/rpcsvc-auth.c
+++ b/rpc/rpc-lib/src/rpcsvc-auth.c
@@ -482,15 +482,13 @@ rpcsvc_auth_array (rpcsvc_t *svc, char *volname, int *autharr, int arrlen)
switch (ret) {
case _gf_true:
- result = RPCSVC_AUTH_ACCEPT;
autharr[count] = auth->auth->authnum;
++count;
break;
- case _gf_false:
- result = RPCSVC_AUTH_REJECT;
- break;
+
default:
- result = RPCSVC_AUTH_DONTCARE;
+ /* nothing to do */
+ break;
}
}