summaryrefslogtreecommitdiffstats
path: root/rpc/rpc-lib/src/protocol-common.h
diff options
context:
space:
mode:
authorNiels de Vos <ndevos@redhat.com>2013-06-17 10:56:55 +0200
committerAnand Avati <avati@redhat.com>2013-06-17 09:34:56 -0700
commiteb6b81e1fc182daba4d202d15362250eee1c86d6 (patch)
tree3c82ee9da06947f10a8fff453de50448e557e756 /rpc/rpc-lib/src/protocol-common.h
parent74fe3057270fabb79f311414dd9c47c6245b52c7 (diff)
protocol/rpc: move latest added procedures to the end of the array
While looking at the newly introduced procedures FALLOCATE and DISCARD, it seems that these were added with already existing procedure numbers. This makes the protocol incompatible with existing roll-outs. It is very confusing when new procedures are added somewhere in the middle of the array. This will cause the number of existing procedures to change. It is much preferred to add new procedures at the end of the array. This changes not only corrects the enum that generates the procedure numbers, but also the ordering in the client and server fops-array for clarity. Correcting this greatly simplifies adding support for these new procedures in Wireshark and will prevent confusion to the people reading network traces (with or without Wireshark). Change-Id: Ib9e7978531d016c7230d756b855cb94cb0793b0f BUG: 974976 Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: http://review.gluster.org/5215 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Anand Avati <avati@redhat.com>
Diffstat (limited to 'rpc/rpc-lib/src/protocol-common.h')
-rw-r--r--rpc/rpc-lib/src/protocol-common.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/rpc/rpc-lib/src/protocol-common.h b/rpc/rpc-lib/src/protocol-common.h
index 0457140..b80a52b 100644
--- a/rpc/rpc-lib/src/protocol-common.h
+++ b/rpc/rpc-lib/src/protocol-common.h
@@ -53,11 +53,11 @@ enum gf_fop_procnum {
GFS3_OP_SETATTR,
GFS3_OP_FSETATTR,
GFS3_OP_READDIRP,
- GFS3_OP_FALLOCATE,
- GFS3_OP_DISCARD,
GFS3_OP_RELEASE,
GFS3_OP_RELEASEDIR,
GFS3_OP_FREMOVEXATTR,
+ GFS3_OP_FALLOCATE,
+ GFS3_OP_DISCARD,
GFS3_OP_MAXVALUE,
} ;