summaryrefslogtreecommitdiffstats
path: root/libglusterfs
diff options
context:
space:
mode:
authorAnand Avati <avati@gluster.com>2011-08-19 14:56:13 +0530
committerAnand Avati <avati@gluster.com>2011-08-19 03:06:19 -0700
commitdd2c197c1d5d5942a65c860997ec1d5793ef249f (patch)
treeb64d3d9af03c042f2da4a9f7cb349d5a0f8bb508 /libglusterfs
parent0143a2ef653d0f7a337c8220f127655dadbca942 (diff)
option validation: further fixes
fixes in option handling changes Change-Id: I0a44cdb088e3f08cd43d583a580736d0903fa88c BUG: 3415 Reviewed-on: http://review.gluster.com/261 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@gluster.com>
Diffstat (limited to 'libglusterfs')
-rw-r--r--libglusterfs/src/options.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/libglusterfs/src/options.c b/libglusterfs/src/options.c
index 37302e0daec..dee3c91854f 100644
--- a/libglusterfs/src/options.c
+++ b/libglusterfs/src/options.c
@@ -501,14 +501,13 @@ xlator_option_validate_addr (xlator_t *xl, const char *key, const char *value,
if (!valid_internet_address ((char *)value)) {
snprintf (errstr, 256,
- "internet address '%s' does not conform to standards.",
+ "internet address '%s' does not conform to standards.",
value);
gf_log (xl->name, GF_LOG_ERROR, "%s", errstr);
+ if (op_errstr)
+ *op_errstr = gf_strdup (errstr);
}
- if (ret && op_errstr)
- *op_errstr = gf_strdup (errstr);
-
ret = 0;
return ret;