diff options
| author | Kaleb S. KEITHLEY <kkeithle@redhat.com> | 2017-12-27 12:33:16 -0500 |
|---|---|---|
| committer | Jeff Darcy <jeff@pl.atyp.us> | 2018-01-02 16:13:19 +0000 |
| commit | 26f00e5eeb3e5c37d3323c0fce87893a3b41bb5b (patch) | |
| tree | cbc999b00029bef0b5156711b317a5b3642717e2 /libglusterfs/src/Makefile.am | |
| parent | 14dbd5da1cae64e6d4d2c69966e19844d090ce98 (diff) | |
libglusterfs: export minimum necessary symbols
minimize risk of symbol collisions in global namespace.
see https://review.gluster.org/#/c/5697/ which Amar has
resurrected.
This is a strawman proposal to use an export-list to
only export the necessary symbols from libglusterfs. I suppose
some of this could be fixed by smarter use of static in the
function definitions.
It's a bit scary to see some of the names we expose. And then
there are the names we use in the reserved namespace.
One step short of going all the way to symbol versions
fixes gluster/glusterfs#382
Change-Id: Ifb848dfc655ef735dd27c73b7729e1188eb817f1
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Diffstat (limited to 'libglusterfs/src/Makefile.am')
| -rw-r--r-- | libglusterfs/src/Makefile.am | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libglusterfs/src/Makefile.am b/libglusterfs/src/Makefile.am index e4fe6125a3d..089261a9183 100644 --- a/libglusterfs/src/Makefile.am +++ b/libglusterfs/src/Makefile.am @@ -13,7 +13,7 @@ libglusterfs_la_CPPFLAGS = $(GF_CPPFLAGS) -D__USE_FILE_OFFSET64 \ -I$(CONTRIBDIR)/xxhash libglusterfs_la_LIBADD = $(ZLIB_LIBS) $(MATH_LIB) $(UUID_LIBS) -libglusterfs_la_LDFLAGS = -version-info $(LIBGLUSTERFS_LT_VERSION) +libglusterfs_la_LDFLAGS = -version-info $(LIBGLUSTERFS_LT_VERSION) -export-symbols $(top_srcdir)/libglusterfs/src/libglusterfs.sym lib_LTLIBRARIES = libglusterfs.la libgfchangelogdir = $(includedir)/glusterfs/gfchangelog @@ -90,7 +90,7 @@ endif libgfchangelog_HEADERS = changelog.h -EXTRA_DIST = graph.l graph.y defaults-tmpl.c +EXTRA_DIST = graph.l graph.y defaults-tmpl.c libglusterfs.sym graph.lex.c: graph.l y.tab.h $(LEX) -Pgraphyy -t $(srcdir)/graph.l > $@ |