diff options
| author | ShyamsundarR <srangana@redhat.com> | 2018-07-30 14:09:14 -0400 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-08-03 08:37:15 +0000 |
| commit | 60f1aeb08df80501caf6b17543592de02d61381f (patch) | |
| tree | ce4a8c5d163a9b4b20aeb8cd99041779455e1b67 /glusterfsd/src/glusterfsd-messages.h | |
| parent | 9e96d646537fd060ca932291aaa0c4a3ce942b67 (diff) | |
coverity: Fix remaining SECURE_TEMP issues reported
Two pending SECURE_TEMP issues still exist in the coverity
reports, these are fixed by this patch.
In both instances (where functions actually seem to be
duplicates of each other) the need was for a FILE * and
not an fd. Applied the same pattern in both places as in
other parts of the code where mkstemp was used and later
a FILE * was created from the resulting fd for use.
Coverity report: https://download.gluster.org/pub/gluster/
glusterfs/static-analysis/master/glusterfs-coverity/
2018-07-30-4d3c62e7/html/
Issues numbered: 382, 383 (named SECURE_TEMP)
Further added tmpfile to the blacklist, so that future code
changes do not add the same, into symbol-check.sh.
Also corrected shellcheck errors in symbol-check.sh as a
result of updating the same.
Updates: bz#789278
Change-Id: I1d572a16ca5b5df2f597aeaa5f454fad34c8296e
Signed-off-by: ShyamsundarR <srangana@redhat.com>
Diffstat (limited to 'glusterfsd/src/glusterfsd-messages.h')
| -rw-r--r-- | glusterfsd/src/glusterfsd-messages.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/glusterfsd/src/glusterfsd-messages.h b/glusterfsd/src/glusterfsd-messages.h index 95fc79ef8d0..e7df714064a 100644 --- a/glusterfsd/src/glusterfsd-messages.h +++ b/glusterfsd/src/glusterfsd-messages.h @@ -61,7 +61,8 @@ GLFS_MSGID(GLUSTERFSD, glusterfsd_msg_35, glusterfsd_msg_36, glusterfsd_msg_37, - glusterfsd_msg_38 + glusterfsd_msg_38, + glusterfsd_msg_39 ); #endif /* !_GLUSTERFSD_MESSAGES_H_ */ |