summaryrefslogtreecommitdiffstats
path: root/extras
diff options
context:
space:
mode:
authorRavishankar N <ranaraya@redhat.com>2014-01-29 12:09:42 +0000
committerVijay Bellur <vbellur@redhat.com>2014-02-17 01:51:03 -0800
commit5b2d308f4b3969e37ceca7648165add1badb0de3 (patch)
treee127a2740ce615e41087267a0ac545e94c8a9f8c /extras
parentb319f01ecd8568659f365f4fa6bbed0acf06db76 (diff)
storage/posix: perform chmod after chown.
Problem: When a replica brick is added to a volume, set-user-ID and set-group-ID permission bits of files are not set correctly in the new brick. The issue is in the posix_setattr() call where we do a chmod followed by a chown. But according to the man pages for chown: When the owner or group of an executable file are changed by an unprivileged user the S_ISUID and S_ISGID mode bits are cleared. POSIX does not specify whether this also should happen when root does the chown(). Fix: Swap the chmod and chown calls in posix_setattr() BUG: 1058797 Change-Id: Id2fbd8394cf6faf669f414775409f20f46009f2b Signed-off-by: Ravishankar N <ravishankar@redhat.com> Reviewed-on: http://review.gluster.org/6988 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'extras')
0 files changed, 0 insertions, 0 deletions