path: root/extras/hook-scripts/stop/pre/
diff options
authorMichael Adam <>2015-12-09 18:57:59 +0100
committerRaghavendra Talur <>2015-12-16 11:13:36 -0800
commit27c16d6da82876a689dfba53b8d45c3a3a657954 (patch)
treee2748469458aa8b9a8aecf8ed8f69f6e04e3f832 /extras/hook-scripts/stop/pre/
parent5e36564754e2d83a7666066f4da7f148960a5694 (diff)
hook-scripts: don't let ctdb script change samba config
There are several reasons why the behaviour in the hook scripts was bad: 1. A samba installation is clustered or non-clustered. That does not change because of the availability of the CTDB lock-volume. If the lock-volume is not available (and hence CTDB is not available or not healthy), then Samba won't be operational. But turning it into a non-clustered Samba-installation can in the worst case lead to data corruption if clients manage to access the same files (on share volumes). Hence 'clustering = yes/no' in Samba's config should not be touched. In particular, Samba should not be stopped/started by the hook script. If needed, then ctdb will take care of it. 2. Changing the idmap configuration is potentially dangerous as well. In particular the used tdb2 backend is legacy nowadays and should not be used any more in new installs. (I stems from the times when ctdb could not host persistent databases.) Changing the idmap can result in loss of access to files or in giving access to files where it is not intended. 3. The pattern used for detecting need for change is fragile. It may or may not play well possible manual changes to smb.conf. This change removes the parts that change the smb.conf file and start or stop Samba from the S29CTDB* hook scripts. Change-Id: I72f7aabafa8f089da4531fca2572a72c22825bcc BUG: 1290151 Signed-off-by: Michael Adam <> Reviewed-on: Tested-by: Gluster Build System <> Reviewed-by: Raghavendra Talur <>
Diffstat (limited to 'extras/hook-scripts/stop/pre/')
1 files changed, 0 insertions, 24 deletions
diff --git a/extras/hook-scripts/stop/pre/ b/extras/hook-scripts/stop/pre/
index 9125030bb7e..9ba8a1cf372 100755
--- a/extras/hook-scripts/stop/pre/
+++ b/extras/hook-scripts/stop/pre/
@@ -1,6 +1,5 @@
#! /bin/bash
#non-portable - RHS-2.0 only
@@ -13,16 +12,6 @@ VOL=
# User needs to set META to the volume that serves CTDB lockfile.
-function sighup_samba () {
- pid=`cat /var/run/`
- if [ "$pid" != "" ]
- then
- kill -HUP $pid;
- else
- /etc/init.d/smb start
- fi
function parse_args () {
ARGS=$(getopt -l $OPTSPEC -name $PROGNAME $@)
eval set -- "$ARGS"
@@ -46,17 +35,6 @@ function parse_args () {
-function remove_ctdb_options () {
- IFS=$'\n'
- GLUSTER_CTDB_CONFIG=$'# ctdb config for glusterfs\n\tclustering = yes\n\tidmap backend = tdb2\n'
- for line in $GLUSTER_CTDB_CONFIG
- do
- sed -i /"$line"/d $SMB_CONF
- done
- unset IFS
function remove_fstab_entry () {
@@ -80,6 +58,4 @@ then
umount "$CTDB_MNT"
chkconfig ctdb off
remove_fstab_entry $CTDB_MNT
- remove_ctdb_options
- sighup_samba