summaryrefslogtreecommitdiffstats
path: root/cli
diff options
context:
space:
mode:
authorJunaid <junaid@gluster.com>2011-06-15 02:41:36 +0000
committerVijay Bellur <vijay@gluster.com>2011-09-09 01:41:25 -0700
commit307c3c4f6e98215cca12eb37d44c03ca1a30be3d (patch)
tree36041ac79f340cf9cdbce9d30653b2d52ada99bf /cli
parent5b4537c70ea46cea055240584d2af9da96359169 (diff)
Fix misleading 'quota remove' output.
Change-Id: I195d3bf81e55886395e98f3eda67127e47014c11 BUG: 2856 Signed-off-by: Junaid <junaid@gluster.com> Reviewed-on: http://review.gluster.com/340 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vijay@gluster.com>
Diffstat (limited to 'cli')
-rw-r--r--cli/src/cli-rpc-ops.c14
1 files changed, 11 insertions, 3 deletions
diff --git a/cli/src/cli-rpc-ops.c b/cli/src/cli-rpc-ops.c
index 61e1dcef273..daeb927657c 100644
--- a/cli/src/cli-rpc-ops.c
+++ b/cli/src/cli-rpc-ops.c
@@ -1325,7 +1325,8 @@ out:
}
int32_t
-gf_cli3_1_print_limit_list (char *volname, char *limit_list)
+gf_cli3_1_print_limit_list (char *volname, char *limit_list,
+ char *op_errstr)
{
int64_t size = 0;
int64_t limit_value = 0;
@@ -1344,6 +1345,11 @@ gf_cli3_1_print_limit_list (char *volname, char *limit_list)
if (!connected)
goto out;
+ if (strcmp (limit_list, "") == 0) {
+ cli_out ("%s", op_errstr?op_errstr:"quota limit not set ");
+ goto out;
+ }
+
if (mkdtemp (mountdir) == NULL) {
gf_log ("cli", GF_LOG_WARNING, "failed to create a temporary "
"mount directory");
@@ -1455,9 +1461,11 @@ gf_cli3_1_quota_cbk (struct rpc_req *req, struct iovec *iov,
}
if (rsp.type == GF_QUOTA_OPTION_TYPE_LIST) {
- if (rsp.limit_list)
+ if (rsp.limit_list) {
gf_cli3_1_print_limit_list (rsp.volname,
- rsp.limit_list);
+ rsp.limit_list,
+ rsp.op_errstr);
+ }
} else {
gf_log ("cli", GF_LOG_INFO, "Received resp to quota command ");
if (rsp.op_errstr)