diff options
| author | Ravishankar N <ravishankar@redhat.com> | 2016-08-31 10:47:45 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2016-08-31 05:10:56 -0700 |
| commit | 2d3292fd29884b16cac058f937f91cfda197eca6 (patch) | |
| tree | 4063d86780513ac5d0da3cb829af3eb0d0a5ddbc /cli/src/cli-cmd-system.c | |
| parent | 513bf9b72fddbd1f69ce4b31b16e0611c84a9378 (diff) | |
cli: Fix double unref of dict
Problem: `gluster system:: uuid get` hangs due to double unref of dict.
Fix:
Remove the unnecessary unref in cli_cmd_uuid_get_cbk(). In the said
function, if calling proc->fn() is sucessful, the dict is automatically
unrefed in its cbk as a part of cli_local_wipe(). If calling proc->fn() fails,
then CLI_STACK_DESTROY() takes care of the unref.
Change-Id: Ib656d200f14a27415b36794a0bdadfe36b0d5306
BUG: 1371775
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/15368
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'cli/src/cli-cmd-system.c')
| -rw-r--r-- | cli/src/cli-cmd-system.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/cli/src/cli-cmd-system.c b/cli/src/cli-cmd-system.c index fc632cfcad2..93aac0b60cc 100644 --- a/cli/src/cli-cmd-system.c +++ b/cli/src/cli-cmd-system.c @@ -319,9 +319,6 @@ out: cli_out ("uuid get failed"); } - if (dict) - dict_unref (dict); - CLI_STACK_DESTROY (frame); return ret; } |