diff options
| author | Xie Changlong <xiechanglong@cmss.chinamobile.com> | 2019-05-17 18:33:11 +0800 |
|---|---|---|
| committer | Xavi Hernandez <xhernandez@redhat.com> | 2019-05-23 08:49:10 +0000 |
| commit | 93156e203c2f51d8a4047889a4c769564b8107b1 (patch) | |
| tree | 479e03d55bd772c9b552f6865d477da55c4697c8 | |
| parent | 3b36543be48e68d20b4df1a8a5ed1c264158af74 (diff) | |
inode: fix wrong loop count in __inode_ctx_free
Avoid serious memory leak
fixes: bz#1711240
Change-Id: Ic61a8fdd0e941e136c98376a87b5a77fa8c22316
Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
| -rw-r--r-- | libglusterfs/src/inode.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/libglusterfs/src/inode.c b/libglusterfs/src/inode.c index 02b4d4938d1..d978326a16c 100644 --- a/libglusterfs/src/inode.c +++ b/libglusterfs/src/inode.c @@ -343,14 +343,15 @@ __inode_ctx_free(inode_t *inode) goto noctx; } - for (index = 0; index < inode->table->xl->graph->xl_count; index++) { + for (index = 0; index < inode->table->ctxcount; index++) { if (inode->_ctx[index].value1 || inode->_ctx[index].value2) { xl = (xlator_t *)(long)inode->_ctx[index].xl_key; - old_THIS = THIS; - THIS = xl; - if (!xl->call_cleanup && xl->cbks->forget) + if (xl && !xl->call_cleanup && xl->cbks->forget) { + old_THIS = THIS; + THIS = xl; xl->cbks->forget(xl, inode); - THIS = old_THIS; + THIS = old_THIS; + } } } |