summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSrijan Sivakumar <ssivakum@redhat.com>2020-09-01 12:48:48 +0530
committerSrijan Sivakumar <ssivakum@redhat.com>2020-09-15 01:10:18 +0000
commit85ff28ace3901a5a54d8de42d33ab2f9ac528ed8 (patch)
treec66f1c10181918bd6fa5fb1370c3988b2382167a
parent93d48622d9ddb96f07a8590312c2885e11751436 (diff)
Events: Fixing coverity issues.
Fixing resource leak reported by coverity scan. CID: 1431237 Change-Id: I2bed106b3dc4296c50d80542ee678d32c6928c25 Updates: #1060 Signed-off-by: Srijan Sivakumar <ssivakum@redhat.com> (cherry picked from commit ebc0253269d8a538239dd0b99d42f56ea320b0f0)
-rw-r--r--libglusterfs/src/events.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/libglusterfs/src/events.c b/libglusterfs/src/events.c
index b397f413bb9..4d720cad6c8 100644
--- a/libglusterfs/src/events.c
+++ b/libglusterfs/src/events.c
@@ -40,6 +40,7 @@ _gf_event(eventtypes_t event, const char *fmt, ...)
char *host = NULL;
struct addrinfo hints;
struct addrinfo *result = NULL;
+ struct addrinfo *iter_result_ptr = NULL;
xlator_t *this = THIS;
char *volfile_server_transport = NULL;
@@ -77,9 +78,10 @@ _gf_event(eventtypes_t event, const char *fmt, ...)
}
// iterate over the result and break when socket creation is success.
- for (; result != NULL; result = result->ai_next) {
- sock = socket(result->ai_family, result->ai_socktype,
- result->ai_protocol);
+ for (iter_result_ptr = result; iter_result_ptr != NULL;
+ iter_result_ptr = iter_result_ptr->ai_next) {
+ sock = socket(iter_result_ptr->ai_family, iter_result_ptr->ai_socktype,
+ iter_result_ptr->ai_protocol);
if (sock != -1) {
break;
}