diff options
| author | Rajesh Joseph <rjoseph@redhat.com> | 2016-05-24 15:10:33 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2016-08-18 21:39:37 -0700 |
| commit | 03003d14e4f052db278aa4edf47cf3b98779ca33 (patch) | |
| tree | 039498c172f31c07b53c88ca83617799d6bd4368 | |
| parent | 490d13b77619be7bb8edeadbfe1e8cf6eb7a0576 (diff) | |
snapshot/uss: log is filled with gfid is NULL error
In snapview-server if the lookup came on missing entry
then it does not have proper context to see if it is the
case of "Stale file handle" or ENOENT. We should not log
this error in GF_LOG_ERROR level, instead this should be
a debug log.
> BUG: 1339149
> Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
> Reviewed-on: http://review.gluster.org/14514
> Smoke: Gluster Build System <jenkins@build.gluster.com>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
> Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
(cherry picked from commit dca1c08c6384e34403d8b5ad6eaf0931529168ac)
BUG: 1367297
Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Change-Id: I8f7cc0e117e9a6dd9482da2e94a56f2ed731a442
Reviewed-on: http://review.gluster.org/15166
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
| -rw-r--r-- | xlators/features/snapview-server/src/snapview-server.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/xlators/features/snapview-server/src/snapview-server.c b/xlators/features/snapview-server/src/snapview-server.c index 338d5bd2f75..72cfc908bba 100644 --- a/xlators/features/snapview-server/src/snapview-server.c +++ b/xlators/features/snapview-server/src/snapview-server.c @@ -612,7 +612,9 @@ svs_lookup (call_frame_t *frame, xlator_t *this, loc_t *loc, dict_t *xdata) if (!inode_ctx && !parent_ctx) { if (gf_uuid_is_null (loc->gfid) && gf_uuid_is_null (loc->inode->gfid)) { - gf_log (this->name, GF_LOG_ERROR, "gfid is NULL"); + gf_log (this->name, GF_LOG_DEBUG, "gfid is NULL, " + "either the lookup came on missing entry or " + "the entry is stale"); op_ret = -1; op_errno = ESTALE; goto out; |