summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnand Avati <avati@gluster.com>2010-04-08 12:23:10 +0000
committerAnand V. Avati <avati@dev.gluster.com>2010-04-08 12:56:55 -0700
commite53cb0787943d51f880daa829aa5699851e985e8 (patch)
tree8856e0a6f9d02138ea6a384e1fec68e9bb63cc93
parent0143139ba85211e8b96ec238c97d0885ae0817b1 (diff)
afr: fix inode ref leak in lookup
first success lookup sets local->cont.lookup with inode_ref and second setting leaks Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 813 (inode ref leak) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=813
-rw-r--r--xlators/cluster/afr/src/afr.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c
index f176ebe7944..4e266113119 100644
--- a/xlators/cluster/afr/src/afr.c
+++ b/xlators/cluster/afr/src/afr.c
@@ -786,8 +786,6 @@ afr_fresh_lookup_cbk (call_frame_t *frame, void *cookie,
dict_unref (local->cont.lookup.xattr);
local->cont.lookup.xattr = dict_ref (xattr);
-
- local->cont.lookup.inode = inode_ref (inode);
local->cont.lookup.xattrs[child_index] = dict_ref (xattr);
local->cont.lookup.postparent = *postparent;
@@ -916,7 +914,6 @@ afr_revalidate_lookup_cbk (call_frame_t *frame, void *cookie,
if (local->cont.lookup.xattr)
dict_unref (local->cont.lookup.xattr);
- local->cont.lookup.inode = inode_ref (inode);
local->cont.lookup.xattr = dict_ref (xattr);
local->cont.lookup.xattrs[child_index] = dict_ref (xattr);
local->cont.lookup.postparent = *postparent;