glusterfs.git/xlators, branch v3.8.1

glusterd: search port from last_alloc to base_port

2016-07-07T13:51:28+00:00

Backport of http://review.gluster.org/14268

If a brick process is killed ungracefully then GlusterD wouldn't receive a
PMAP_SIGNOUT event and hence the stale port details wouldn't be removed out.

Now consider the following case:
1. Create a volume with 1 birck
2. Start the volume (say brick port allocated is 49152)
3. Kill the brick process by 'kill -9'
4. Stop & delete the volume
5. Recreate the volume and start it. (Now the brick port gets 49153)
6. Mount the volume

Now in step 6 mount will fail as GlusterD will provide back the stale port
number given the query starts searching from the base_port.

Solution:

To avoid this, searching for port from last_alloc and coming down to base_port
should solve the issue.

>Change-Id: I9afafd722a7fda0caac4cc892605f4e7c0e48e73
>BUG: 1334270
>Signed-off-by: Atin Mukherjee 
>Reviewed-on: http://review.gluster.org/14268
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Samikshan Bairagya 
>Reviewed-by: Jeff Darcy 

Change-Id: I9afafd722a7fda0caac4cc892605f4e7c0e48e73
BUG: 1353426
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14867
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaushal M

Fix opRet value for volume info --xml call on non-existent volume

2016-07-07T04:17:50+00:00

The opRet field was being assigned to 0 in the XML output when a
gluster volume info --xml call is made on a non-existent volume.
This change assigns a value of -1 to opRet for volume info calls
for non-existent volumes. Other fields like opErrno and opErrstr
are also assigned relevant values

> Reviewed-on: http://review.gluster.org/13843
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: darshan n 
> Reviewed-by: Atin Mukherjee 
> NetBSD-regression: NetBSD Build System 

(cherry picked from commit a6e551122c603ab0cba798e7e2b30d3a15191b68)

Change-Id: I3920c602328f74252c87bb521f5a43d4bdc7d44d
BUG: 1352880
Signed-off-by: Samikshan Bairagya 
Reviewed-on: http://review.gluster.org/14863
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: compare uuid instead of hostname address resolution

2016-07-05T14:43:24+00:00

Backport of http://review.gluster.org/14849

In glusterd_get_brickinfo () brick's hostname is address resolved. This adds an
unnecessary latency since it uses calls like getaddrinfo (). Instead given the
local brick's uuid is already known a comparison of MY_UUID and brickinfo->uuid
is much more light weight than the previous approach.

On a scale testing where cluster hosting ~400 volumes spanning across 4 nodes,
if a node goes for a reboot, few of the bricks don't come up. After few days of
analysis its found that glusterd_pmap_sigin () was taking signficant amount of
latency and further code walthrough revealed this unnecessary address
resolution. Applying this fix solves the issue and now all the brick processes
come up on a node reboot.

Backport of commit 633e6fe265bc2de42dade58dc6a15c285957da76:
> Change-Id: I299b8660ce0da6f3f739354f5c637bc356d82133
> BUG: 1352279
> Signed-off-by: Atin Mukherjee 
> Reviewed-on: http://review.gluster.org/14849
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Prashanth Pai 
> Reviewed-by: Samikshan Bairagya 
> Reviewed-by: Kaushal M 

Change-Id: I299b8660ce0da6f3f739354f5c637bc356d82133
BUG: 1352817
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14860
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System

glusterd/geo-rep: Add relative path validation to copy file command

2016-07-05T11:58:48+00:00

Added validation for input file, command fails if input file path is
relative path pointing outside of GLUSTERD_WORKDIR.

BUG: 1350785
Change-Id: I329d43ebed69bfe9fe03d6be70dc8c78a605ffc5
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/14772
(cherry picked from commit 888de8851e718d8e3117e47fa35cfc075b998f62)
Reviewed-on: http://review.gluster.org/14819
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

protocol/server: Fix client/server compatibility

2016-07-05T11:57:59+00:00

The 3.8 client expects a child_up key from the server
indicating the status of the server translators. This
key is not being sent by the servers running older
versions, thereby breaking compatibility.

With this patch we are treating the absence of the said
key as an indication that the server trying to connect
to this client is running an older version and hence
in such a case we are setting conf->child_up as
_gf_true explicitly. This should suffice in emulating
the older behavior.

Due to the nature of this bug, requiring two version to
be reproducible, there are no testcases added for the same.

> Reviewed-on: http://review.gluster.org/14811
> Reviewed-by: Raghavendra G 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> Tested-by: Gluster Build System 

(cherry picked from commit 10fa1bcce3b73f630dbc3241722c1af9dee4c414)

Change-Id: I29e0a5c63b55380dc9db8e42852d7e95b64a2b2e
BUG: 1350326
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/14810
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

cluster/ec: Fix race in timer cancellation

2016-07-04T13:28:08+00:00

A race in timer cancellation for delayed unlock could cause a crash
if the cancelling thread fails to cancel the timer because it has
already been fired but not executed, and the callback is scheduled
out of the CPU, delaying it until the thread has released important
resources needed by the callback.

This patch improves the handling of this case to make it robust.

Backport of:
> Change-Id: I5c8a8c6610c5136f71b938aa78b5878ba05238d4
> BUG: 1345855
> Signed-off-by: Xavier Hernandez 
> Reviewed-on: http://review.gluster.org/14712
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 

Change-Id: I5c8a8c6610c5136f71b938aa78b5878ba05238d4
BUG: 1346158
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/14723
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

glusterd/cli: coverity fixes

2016-07-04T10:19:56+00:00

Backport of http://review.gluster.org/#/c/14818/

A downstream coverity run has revealed few of the following coverity defects.
Since the downstream code is a clone of a specific upstream branch the defects
hold true for the upstream as well.

Defect type: NEGATIVE_RETURNS
xlators/mgmt/glusterd/src/glusterd-rpc-ops.c:641: negative_returns: "op_errno"
is passed to a parameter that cannot be negative.

Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-volume-ops.c:2124: buffer_size_warning:
Calling strncpy with a maximum size argument of 261 bytes on destination array
"volinfo->volname" of size 261 bytes might leave the destination string
unterminated.

Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-volgen.c:4888: buffer_size_warning: Calling
strncpy with a maximum size argument of 261 bytes on destination array
"volinfo->volname" of size 261 bytes might leave the destination string
unterminated.

Defect type: STRING_OVERFLOW
xlators/mgmt/glusterd/src/glusterd-volgen.c:3449: string_overflow: You might
overrun the 256 byte destination string "tmp_volname" by writing 261 bytes from
"volinfo->volname".

Defect type: BUFFER_SIZE_WARNING
xlators/mgmt/glusterd/src/glusterd-utils.c:3392: buffer_size_warning: Calling
strncpy with a maximum size argument of 261 bytes on destination array
"new_volinfo->volname" of size 261 bytes might leave the destination string
unterminated.

Defect type: NO_EFFECT
xlators/mgmt/glusterd/src/glusterd-utils.c:7359: remediation: Was
"rebal->rebalance_id" formerly declared as a pointer?

Defect type: USE_AFTER_FREE
xlators/mgmt/glusterd/src/glusterd-utils.c:7115: pass_freed_arg: Passing freed
pointer "volinfo" as an argument to "glusterd_friend_contains_vol_bricks".

Defect type: DEADCODE
cli/src/cli-cmd-parser.c:1767: dead_error_begin: Execution cannot reach this
statement: "ret = -1;".

Change-Id: Ie941bdf31923e2f39618dd94bfae16fdb3ad65f1
BUG: 1352281
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14818
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/14850
Reviewed-by: Prashanth Pai

glusterd/ganesha : persist value set by teardown in info file

2016-07-04T05:39:18+00:00

During teardown, all the volumes exported via NFS-Ganesha will be
unexported. So all related volume options need to reset. Currently
this change made using dict_set on volopt dictionary, i.e change
is only reflected in memory not persisted in the volume info file
Therefore incase of glusterd restart this data can be lost.

Also this patch fix similar issue in ganesha_manage_export().

Upstream reference :
>Change-Id: Ib843ac30adb28a70e13a9a1df57020ef2f3db8a4
>BUG: 1349270
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/14778
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Kaleb KEITHLEY 
>Reviewed-by: Atin Mukherjee 
>(cherry picked from commit 16c34b101f604a09a5c735fb39815c59ee4ecbdb)

Change-Id: Ib843ac30adb28a70e13a9a1df57020ef2f3db8a4
BUG: 1351151
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14831
Reviewed-by: Atin Mukherjee 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

libglusterfs: Implement API that provides page-aligned iobufs

2016-06-29T09:53:40+00:00

        Backport of: http://review.gluster.org/14672

One of the consumers of a page aligned buffer would be posix's
readv fop on O_DIRECT fds. Today the way it works is by getting
a page-aligned buffer through calloc, pread()ing into this buffer
and then copying its contents into a newly created iobuf's ptr.
This results in an extra memcpy() which can be avoided if we could
implement an api that would return an iobuf whose ptr is
page-aligned. That way the iobuf->ptr can be directly passed to
sys_pread() as a parameter by posix translator.

Change-Id: I7f64419461db387e4ab6b0e03c90471744aa56e1
BUG: 1351025
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/14825
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

features/index: Do deletion of name-index in unwind path

2016-06-28T10:47:03+00:00

        Backport of: http://review.gluster.org/14742

Previously the deletion of name index was being done before
winding the xattrop to posix. This order needs to be changed
to ensure we don't lose the index in the event the xattrop fails
in posix xl.

Change-Id: If0d713645858c9dce6d4a9c5d9ea27ccb0cfa29f
BUG: 1349711
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/14787
Reviewed-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
Reviewed-by: Ravishankar N 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System