glusterfs.git/xlators, branch v3.7.9

mount/fuse: cleanup an additional inode_ref()

2016-03-17T20:05:20+00:00

commit ca515db0127 introduced a check in
fuse_resolve_inode_simple(). This results in an additional
ref being held on inodes which were obtained through readdirp.
As a result, the inode table keeps growing and entries remain in
the active list even after deletion of such inodes from the volume.

Change-Id: I780ec5513990d6ef00ea051ec57ff20e4428081e
BUG: 1317959
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/13745
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

cluster/tier: break out of iterating query file once cycle time ends

2016-03-17T04:37:48+00:00

When iterating the query file during migration, tiering should
break out of the loop once cycle time completes. Otherwise it
may be possible to stay in the loop for a long time. If that
happens updates to files will become stale and have not impact
migration.

This is a backport of 13284

> Change-Id: Ib60cf74bc84e8646e6a0da21ff04954b1b83c414
> BUG: 1301227
> Signed-off-by: Dan Lambright 
> Reviewed-on: http://review.gluster.org/13284
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
Signed-off-by: Dan Lambright 

Change-Id: Ia305784b0aa570b70e54f532bf5d68a91b0cf305
BUG: 1318203
Reviewed-on: http://review.gluster.org/13750
Smoke: Gluster Build System 
Reviewed-by: hari gowtham 
Tested-by: Dan Lambright 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

snapshot: Fix parent volinfo corruption in snapshot restore

2016-03-11T08:06:55+00:00

    Backport of http://review.gluster.org/#/c/13282/

Remove parent_volinfo irrespective of success or failure
of glusterd_lvm_snapshot_remove(). This prevents the
duplication of the volinfo after the execution of
glusterd_snapshot_restore().

When commit fails on originator node, we don't perform
commit on the other nodes, as a result we don't have a
backup of /var/lib/glusterd/vols/ in the
GLUSTERD_TRASH in other nodes. But in the postvalidate
we try to restore from GLUSTED_TRASH and end up cleaning
up /var/lib/glusterd/vols/. Hence moved
glusterd_snapshot_backup_vol() from commit to prevalidate,
so that the backup is always available when a cleanup is
needed.

Change-Id: Icd471b23faf02bad680b9a1aadc4a0175f7cce8b
BUG: 1301030
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13282
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit 3f78b6b3dc6376945a1b1a7c4af16103901ab746)
Reviewed-on: http://review.gluster.org/13548

glusterd: fixing few memory leak in glusterd

2016-03-10T15:20:04+00:00

This patch is backport of: http://review.gluster.org/#/c/12927/

Current glusterd code base having memory leak. This is because of
memory allocate by dict_allocate_and_serialize function in
"gd_syncop_mgmt_v3_lock" and "gd_syncop_mgmt_v3_unlock"
function is not freeing up memory upon exit.

Fix is to free the memory after exit of the above function.

Thanks Carlos and Roman for finding out the issue and fix.

 >> Change-Id: Id67aa794c84969830ca7ea8c2374f80c64d7a639
 >> BUG: 1287517
 >> Signed-off-by: Gaurav Kumar Garg 
 >> Signed-off-by: Carlos Chinea 
 >> Signed-off-by: Roman Tereshonkov 
 >> Reviewed-on: http://review.gluster.org/12927
 >> Smoke: Gluster Build System 
 >> NetBSD-regression: NetBSD Build System 
 >> CentOS-regression: Gluster Build System 
 >> Reviewed-by: Jeff Darcy 

Change-Id: Id67aa794c84969830ca7ea8c2374f80c64d7a639
BUG: 1311377
Signed-off-by: Gaurav Kumar Garg 
(cherry picked from commit e38bf1bdeda3c7a89be3193ad62a72b9139358dd)
Reviewed-on: http://review.gluster.org/13503
Smoke: Gluster Build System 
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

fuse: Add a new mount option capability

2016-03-10T03:09:43+00:00

Originally all security.* xattrs were forbidden if selinux is disabled,
which was causing Samba's acl_xattr module to not work, as it would
store the NTACL in security.NTACL. To fix this http://review.gluster.org/#/c/12826/
was sent, which forbid only security.selinux. This opened up a getxattr
call on security.capability before every write fop and others.

Capabilities can be used without selinux, hence if selinux is disabled,
security.capability cannot be forbidden. Hence adding a new mount
option called capability.

Only when "--capability" or "--selinux" mount option is used,
security.capability is sent to the brick, else it is forbidden.

Backport of : http://review.gluster.org/#/c/13540/ &
              http://review.gluster.org/#/c/13653/

BUG: 1309462
Change-Id: Ib8d4f32d9f1458f4d71a05785f92b526aa7033ff
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/13626
Tested-by: Vijay Bellur 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Vijay Bellur

features/bit-rot-stub: get frame->local before unwinding

2016-03-09T19:29:26+00:00

In bit-rot-stub, if unlink fails, then it was unwinding
directly. Then it was trying to cleanup local. But local
would be NULL, since it was unwinding directly without getting
the value of frame->local. The NULL cleanup of local was
causing the brick process to crash.

Change-Id: I8544ba73b2e8dc0c50b1a53ff8027d85588d087b
BUG: 1315552
Signed-off-by: Raghavendra Bhat 
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/13630
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

features/shard: Return ENOTSUP for unsupported fallocate flags

2016-03-09T12:05:08+00:00

        Backport of: http://review.gluster.org/13523

Basis: http://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05101.html

Change-Id: I681eb4d0c43c635cf96a2deab0996dec7a255fe5
BUG: 1299712
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/13652
Smoke: Gluster Build System 
Reviewed-by: Ravishankar N 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: volume get should pick options from priv->opts too

2016-03-09T07:25:52+00:00

Backport of http://review.gluster.org/13272

As of now volume get was not looking for all the global options maintained in
option dictionary in glusterd_conf_t. This patch includes the same.

Change-Id: Ib05259a2dcacc4a712cae4217fe4a6553b61da56
BUG: 1315939
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13272
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Gaurav Kumar Garg 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/13651

glusterd: avoid setting op-version lower than current cluster op-version

2016-03-09T02:18:12+00:00

This patch is backport of: http://review.gluster.org/#/c/13622/

Currently glusterd allow setting a cluster op-version which is lower than
current cluster op-version. Though command is successful but it does not
set that lower op-version.

With this fix it will return error message "Required op-version
(requested op-version) should not be lower than current cluster
op-version (current cluster op-version)"

Change-Id: Ia5b61858ee22a5a26721ec12ab12ff48e1a40c82
BUG: 1315562
Signed-off-by: Gaurav Kumar Garg 

  >> Change-Id: Ia5b61858ee22a5a26721ec12ab12ff48e1a40c82
  >> BUG: 1315186
  >> Signed-off-by: Gaurav Kumar Garg 
  >> Reviewed-on: http://review.gluster.org/13622
  >> Smoke: Gluster Build System 
  >> CentOS-regression: Gluster Build System 
  >> NetBSD-regression: NetBSD Build System 
  >> Reviewed-by: Atin Mukherjee 
(cherry picked from commit 2d87a981657ee23d00c20813deddeb320e0afa8f)

Change-Id: Ie75b2a0c43ab2c5a908f4d3800e1df62770d315b
Reviewed-on: http://review.gluster.org/13635
Tested-by: Gaurav Kumar Garg 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

afr: misc performance improvements

2016-03-09T02:16:32+00:00

Backport of http://review.gluster.org/#/c/13595/
1. In afr_getxattr_cbk, consider the errno value before blindly
launching an inode refresh and a subsequent retry on other children.

2. We want to accuse small files only when we know for sure that there
is no
IO happening on that inode. Otherwise, the ia_sizes obtained in the
post-inode-refresh replies may mismatch due to a race between
inode-refresh and ongoing writes, causing spurious heal launches.

Change-Id: I9858485d1061db67353ccf99c59530731649c847
BUG: 1309462
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/13644
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Krutika Dhananjay 
CentOS-regression: Gluster Build System