glusterfs.git/xlators, branch v3.7.7

glusterd: improve error logs for unsupported clients

2016-02-01T11:03:12+00:00

Backport of http://review.gluster.org/11831

Change-Id: I90be46a7b25cc3efd0e61c9a145852e9027f5f64
BUG: 1302521
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11831
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Kaushal M 
NetBSD-regression: NetBSD Build System 
Reviewed-on: http://review.gluster.org/13305

cluster/tier: Ignore quota-deem-statfs for watermark calculation

2016-02-01T05:06:51+00:00

The tier process watermark calculations were incorrect when the
quota-deem-statfs option was enabled. We now ignore this while
calculating hot tier usage to determine watermark levels.

Change-Id: I308bc24432e2fa5ad1d5703e80fc391433538bbb
BUG: 1302012
> Signed-off-by: N Balachandran 
> Reviewed-on: http://review.gluster.org/13288
> Smoke: Gluster Build System 
> Reviewed-by: mohammed rafi  kc 
> Tested-by: mohammed rafi  kc 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Dan Lambright 
> NetBSD-regression: NetBSD Build System 
> Tested-by: Dan Lambright 
(cherry picked from commit 9ce86c63e349eaafbd923b0b541d75e929ecbae7)
Signed-off-by: Nithya Balachandran 
Reviewed-on: http://review.gluster.org/13292
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

cluster/ec: Create this->itable in all cases

2016-01-31T02:27:07+00:00

Problem:
glfsheal operates based on mount's volfile which doesn't have iamshd flag due
to which this->itable is NULL, this leads to "inode not found" logs in glfsheal
logs.

Fix:
Ec only allocates itable with 10 inodes, so allocating this->itable in all
cases in init.

 >Change-Id: I01d3c05e93a17007a4716a2d6f392d2aa306a34b
 >BUG: 1294743
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/13112
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 
 >(cherry picked from commit 080ddb79d8805253a7f4274606351570faae1add)

Change-Id: I4fb624fc26d47128221322da077d04b12add6452
Signed-off-by: Pranith Kumar K 
BUG: 1302943
Reviewed-on: http://review.gluster.org/13312
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

snapd: Do not persist snapd port

2016-01-31T02:26:57+00:00

    Backport of http://review.gluster.org/#/c/13118/

Currently snapd persists the port it uses
to sign-in with glusterd, without checking
if that particular port is being used by any
other process. As a result, it might erroneously
sign out any other process using the same port.

Hence forcing snapd to ignore the persisted port,
and using a new one while coming up.

Change-Id: Ibb9ec3762aac445f03d96e85660585be4ab27bcb
BUG: 1294797
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13119
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

cluster/afr: change data self-heal size check for arbiter

2016-01-31T02:26:55+00:00

Size mismatch should consider that arbiter brick will have zero size file to
prevent data self-heal to spuriously trigger/assuming need of self-heals.

 >Change-Id: I179775d604236b9c8abfa360657abbb36abae829
 >BUG: 1285634
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/12755
 >Reviewed-by: Ravishankar N 
 >Tested-by: Gluster Build System 
 >Tested-by: NetBSD Build System 
 >(cherry picked from commit 8d2594d77127ba7ea07a0d68afca0939e1817e39)

Change-Id: I90243c01d6d83f46475c975a9bd34d9de84b87da
BUG: 1283956
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12768
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

dht : changing variable type to avoid overflow

2016-01-29T08:42:44+00:00

For layout computation we find total size of the cluster
and store it in an unsigned 32 bit variable. For large
clusters this value may overflow which leads to wrong
computations and for some bricks the layout may overflow.
Hence using unsigned 64 bit to handle large values.

> Backport of http://review.gluster.org/12597

> Change-Id: I7c3ba26ea2c4158065ea9e74705a7ede1b6759c7
> BUG: 1282751
> Signed-off-by: Sakshi Bansal 
> Reviewed-on: http://review.gluster.org/12597
> Reviewed-by: Susant Palai 
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 

BUG: 1294969
Change-Id: Ia66587c6ae4aa3a25b3ac73920b514c1d3c4c2cb
Signed-off-by: Sakshi Bansal 
Reviewed-on: http://review.gluster.org/13127
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

cluster/dht : Ftruncate on migrating file fails with EINVAL

2016-01-29T08:42:30+00:00

What:
If dht_open is called on a migrating file after the inode_ctx is set,
subsequent FOPs on that fd do not open the fd on the dst subvol.
This is seen when the open-ftruncate-close sequence is repeatedly
called on a migrating file.
A second call to the sequence described above causes dht_truncate_cbk
to call dht_truncate2 as the dht_inode_ctx was already set by the first
call. As dht_rebalance_in_progress_check is not called, the fd is not
opened on the dst subvol.
On a distributed-replicate volume, this causes AFR to
open the fd using afr_fix_open, but with the wrong flags, causing
posix_ftruncate to fail with EINVAL.
The fix: We require fd specific information to make a decision while
handling migrating files.
Set the fd_ctx to indicate the fd has been opened on the dst subvol
and check if it has been set while processing Phase1/Phase2 checks
in the FOP callback functions.

> Change-Id: I43cdcd8017b4a11e18afdd210469de7cd9a5ef14
> Signed-off-by: N Balachandran 
> Reviewed-on: http://review.gluster.org/12985
> Reviewed-by: Raghavendra G 
> Tested-by: Gluster Build System 
> Reviewed-by: Dan Lambright 
> Tested-by: Dan Lambright 

Change-Id: I99f8aceec105f16631def06a263f0561954d14b3
BUG: 1293827
Signed-off-by: N Balachandran 
Reviewed-on: http://review.gluster.org/13071
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

cluster/afr: Fix data loss due to race between sh and ongoing write.

2016-01-29T01:43:33+00:00

        Backport of: http://review.gluster.org/#/c/13001/

Problem:

When IO is happening on a file and a brick goes down comes back up
during this time, protocol/client translator attempts reopening of the
fd on the gfid handle of the file. But if another client renames this
file while a brick was down && writes were in progress on it, once this
brick is back up, there can be a race between reopening of the fd and
entry self-heal replaying the effect of the rename() on the sink brick.
If the reopening of the fd happens first, the application's writes
continue to go into the data blocks associated with the gfid.
Now entry-self-heal deletes 'src' and creates 'dst' file on the sink,
marking dst as a 'newentry'.  Data self-heal is also completed on 'dst'
as a result and self-heal terminates. If at this point the application
is still writing to this fd, all writes on the file after self-heal
would go into the data blocks associated with this fd, which would be
lost once the fd is closed. The result - the 'dst' file on the source
and sink are not the same and there is no pending heal on the file,
leading to silent corruption on the sink.

Fix:

Leverage http://review.gluster.org/#/c/12816/ to ensure the gfid handle
path gets saved in .glusterfs/unlink until the fd is closed on the file.
During this time, when self-heal sends mknod() with gfid of the file,
do the following:
link() the gfid handle under .glusterfs/unlink to the new path to be
created in mknod() and
rename() the gfid handle to go back under .glusterfs/ab/cd/.


Change-Id: I5dc49c127ef0a1bf3cf4ce1b24610b1527f84d6f
BUG: 1293265
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/13036
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

features / bitrot: Prevent spurious pthread_cond_wait() wakeup

2016-01-28T13:29:08+00:00

        Backport of http://review.gluster.org/13302

pthread_cond_wait() is prone to spurious wakeups and it's utmost
necessarry to check a boolean predicate for thread continuation.

See man(3) pthread_cond_wait() for details.

The following is done in bitrot scrubber:

    if (list_empty (&fsscrub->scrublist))
       pthread_cond_wait (&fsscrub->cond, &fsscrub->mutex);

followed by:

    list_first_entry (&fsscrub->scrublist, ...)

A spurious wakeup from pthread_cond_wait() with the absence of
list_empty() check causes list_first_entry() to return garbage.

BUG: 1302199
Change-Id: I60151eabb8af257a35acd8e7c117876388166a0e
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/13307
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

features/bitrot: Fail node-uuid getxattr if file is marked bad

2016-01-27T11:46:01+00:00

If xattr is node-uuid and the inode is marked bad, fail getxattr
and fgetxattr with EIO. Returning EIO would result in AFR to
choose correct node-uuid coresponding to the subvolume where
the good copy of the file resides.

BUG: 1296795
Change-Id: I3f8dc807794f9a82867807e7c4c73ded6c64fd8a
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/13116
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/13194
Tested-by: Venky Shankar 
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System