glusterfs.git/xlators, branch v3.6.9

quota : avoid "contribution node is empty" error logs

2016-02-18T14:35:39+00:00

In versions older than 3.7, "contribution node list is empty which is
an error" gets logged numerous number of times. It is completely fixed
in 3.7. Since the entire marker and quota code has almost been
refactored, it is hard to backport the complete fix and also it could
not be fixed with the older approach. As a temporary fix, to avoid
numerous logs, the patch just supresses the log level.

3.5 fix: http://review.gluster.org/#/c/12990/

> Change-Id: Ie666ba99c7bb16b9ce249b581e09857734589f51
> BUG: 1288195
> Signed-off-by: Manikandan Selvaganesh 

Change-Id: Ie666ba99c7bb16b9ce249b581e09857734589f51
BUG: 1302310
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/13304
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijaikumar Mallikarjuna 
NetBSD-regression: NetBSD Build System

core : Use correct path in dlopen for socket.so

2015-12-16T11:29:23+00:00

Backport of http://review.gluster.org/12656

This patch fixes the path for socket.so file while loading the so dynamically.
Also for config.memory-accounting & config.transport voltype is changed to
glusterd to fix the warning message coming from xlator_volopt_dynload

Change-Id: I0f7964814586f2018d4922b23c683f4e1eb3098e
BUG: 1283834
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/12656
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/12671
Reviewed-by: Raghavendra Bhat

fuse: pass default SElinux mount options on to the kernel

2015-12-16T11:27:13+00:00

In order to set default SElinux contexts on a Gluster mount, the
standard SElinux mount options need to be passed to the kernel. The
mount(8) manual page lists "context", "fscontext", "defcontext" and
"rootcontext" as valid options.

        Backport of http://review.gluster.org/#/c/12858/

Cherry-picked from commit 5e81233f0a3c153e03c437a164ac2ca21314bdec
> BUG: 1287763
> Change-Id: I015fe27e4c6ff36a030e3480b23141aca2d91fc2
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/12858
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: Humble Devassy Chirammal 
> Reviewed-by: Manikandan Selvaganesh 

BUG: 1287878
Change-Id: I015fe27e4c6ff36a030e3480b23141aca2d91fc2
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/12871
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

protocol/client: prevent use-after-free of frame->root

2015-11-25T06:38:47+00:00

A regression failure generated a coredump on the glusterfs-client side:

  (gdb) f 0
  #0  0x00007fba6cd76432 in client_submit_request (this=0x7fba68006fc0,
                  req=0x7fba6579aa70, frame=0x7fba5c0058cc,
                  prog=0x7fba6cfb53c0 , procnum=41,
                  cbkfn=0x7fba6cd9206d ,
                  iobref=0x0, rsphdr=0x0, rsphdr_count=0,
                  rsp_payload=0x0, rsp_payload_count=0, rsp_iobref=0x0,
                  xdrproc=0x7fba79801075 ) at
  /home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/protocol/client/src/client.c:324
  324                   frame->root->ngrps = ngroups;
  (gdb) l
  319                   gf_msg_debug (this->name, 0, "rpc_clnt_submit failed");
  320           }
  321
  322           if (!conf->send_gids) {
  323                   /* restore previous values */
  324                   frame->root->ngrps = ngroups;
  325                   if (ngroups <= SMALL_GROUP_COUNT)
  326                           frame->root->groups_small[0] = gid;
  327           }
  328
  (gdb) p *frame->root
  Cannot access memory at address 0x64185df000000000

After looking at this in more detail, the flow is like this:

  client_submit_request()
    |
    '- rpc_clnt_submit() // on line 314
         |
         '- cbkfn() // = client3_3_release_cbk
              |
              :- STACK_DESTROY (frame->root);
         .----'
    .----'
    |
    :- frame->root->ngrps = ngroups; // on line 324
    '

So, there is a use-after-free, and it is not needed to restore the
previous groups in frame->root.

Cherry picked from commit dc3aa7524e4974f9d02465e2e5dd6ed9b6d319e1:
> Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
> BUG: 1281285 (was incorrect in original patch)
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/12575
> Reviewed-by: Dan Lambright 
> Tested-by: NetBSD Build System 
> Reviewed-by: Jeff Darcy 

Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
BUG: 1283690
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12665
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Raghavendra Bhat

glusterd: call glusterd_store_volinfo in bump up op-version

2015-11-18T12:43:53+00:00

After an upgrade, op-version is expected to be updated through gluster volume
set. If the new version introduces any feature which changes volinfo structure
without storing the default values of these new options would result into cksum
issues.

Backport of:
>Change-Id: I57b4667f3403839811735bf66bef29e5200a9241
>BUG: 1262805
>Signed-off-by: Atin Mukherjee 
>Reviewed-on: http://review.gluster.org/12171
>Tested-by: Gluster Build System 
>Reviewed-by: Krishnan Parthasarathi 
>Reviewed-by: Gaurav Kumar Garg 
>(cherry picked from commit c3ed484af54e32c1ef2300cda652604d75dc9d20)

Change-Id: I0c8d3cc7722b4a04e129c01792b80e27a7e8e59f
BUG: 1277823
Reviewed-on: http://review.gluster.org/12500
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Bhat

glusterd: fix info file checksum mismatch during upgrade

2015-11-18T12:43:27+00:00

issue: probing a new  node(>=3.6)  from 3.5 cluster is moving the peer to rejected state.

fix: Disperse vol support is added from 3.6 release, so write disperse fields (disperse_count=0
and redundancy_count=0) in vol info file  only if cluster version supported.

Backport of:
>Change-Id: I11d5e2e337b9bbaddc8e52ca7295ba481beb1132
>BUG: 1276423
>Signed-off-by: anand 
>Reviewed-on: http://review.gluster.org/12464
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: Gluster Build System 
>Reviewed-by: Kaushal M 
>Tested-by: NetBSD Build System 
>(cherry picked from commit d29dd0747dbb2e7383867c97cbbaa8c41851db78)

Change-Id: I8351457d15e76936851128eb8609746ae87d5aa8
BUG: 1277822
Signed-off-by: anand 
Reviewed-on: http://review.gluster.org/12501
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Bhat

marker: validate loc before starting txn

2015-09-21T13:10:51+00:00

Change-Id: Icdda430ae5dbe182ddff119aa4617548c39832e4
BUG: 1259578
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12180
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Raghavendra Bhat

quota/marker: set lk_owner when taking lock on parent in rename

2015-09-21T06:49:16+00:00

This is a backport of http://review.gluster.org/#/c/11561/

Before doing a rename operation marker takes inode lock on the file
parent,
here lk_owner is NULL and this can cause accounting problem with
multiple rename on the same directory

This patch fix the problem by setting lk_owner

> Change-Id: Ibb789e39b2833e425d0a5fca85282ff1465206cb
> BUG: 1240598
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/11561
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 
> Reviewed-by: Raghavendra G 

Change-Id: I54db6c27791862e84eaa958fc9fdc363a22eb2e8
BUG: 1247972
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11795
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Raghavendra Bhat

fuse: add "resolve-gids" mount option to overcome 32-groups limit

2015-09-21T06:45:07+00:00

Add a --resolve-gids commandline option to the glusterfs binary. This
option gets set when executing "mount -t glusterfs -o resolve-gids ...".

This option is most useful in combination with the "acl" mount option.
POSIX ACL permission checking is done on the FUSE-client side to improve
performance (in addition to the checking on the bricks).

The fuse-bridge reads /proc/$PID/status by default, and this file
contains maximum 32 groups. Any local (client-side) permission checking
that requires more than the first 32 groups will fail.

By enabling the "resolve-gids" option, the fuse-bridge will call
getgrouplist() to retrieve all the groups from the user accessing the
mountpoint. This is comparable to how "nfs.server-aux-gids" works.

Note that when a user belongs to more than ~93 groups, the volume option
server.manage-gids needs to be enabled too. Without this option, the
RPC-layer will need to reduce the number of groups to make them fit in
the RPC-header.

Cherry picked from commit 64a5bf3749c67fcc00773a2716d0c7b61b0b4417:
> Change-Id: I7ede90d0e41bcf55755cced5747fa0fb1699edb2
> BUG: 1246275
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11732
> Tested-by: NetBSD Build System 
> Reviewed-by: Ravishankar N 
> Tested-by: Gluster Build System 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Kaleb KEITHLEY 

Change-Id: I7ede90d0e41bcf55755cced5747fa0fb1699edb2
BUG: 1252072
Tested-by: Patrick Glomski 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11876
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Raghavendra Bhat

afr: launch index heal on local subvols up on a child-up event

2015-09-09T11:53:48+00:00

Backport of http://review.gluster.org/#/c/11912/

Problem: When a replica's child goes down and comes up, the index heal is
triggered only on the child that just came up. This does not serve the intended
purpose as the list of files that need to be healed to this child is actually
captured on the other child of the replica.

Fix: Launch index-heal on all local
children of the replica xlator which just received a child up. Note that
afr_selfheal_childup() eventually calls afr_shd_index_healer() which will not
run the heal on non-local children.

Change-Id: I524fda17c28864758b35679cfb232f81f8374571
BUG: 1256245
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/11994
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat