glusterfs.git/xlators, branch v3.3.0qa30

rpc-clnt: separate out connection_cleanup() from destroy()

2012-03-19T16:14:40+00:00

noticed that there are possibilities where one would like to do a
connection_cleanup() before destroying a RPC connection itself, also
current code is such that, rpc_clnt_connection_cleanup() does
rpc_clnt_ref() and unref(), creating a race window/double unref
possibilities in the code.

by separating out the functions, this race window/double fault can be
prevented.

Change-Id: I7ebd3392efa891232857b6db9108b0b19e40fc12
Signed-off-by: Amar Tumballi 
BUG: 802403
Reviewed-on: http://review.gluster.com/2979
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client: Handle failures in lock self healing gracefully (part 1).

2012-03-19T16:05:58+00:00

During reopening of fd's and reacquiring of locks on the fd (after a
reconnect), a release on a fd on which reacquiring of locks is in progress
will free up fdctx. This patch will keep fdctx valid until the reacquiring
of locks is in progress.

Change-Id: I0464c751a5aa986abac0b72b48b261fceeba24e8
BUG: 795386
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2937
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

protocol/server: Handle server send reply failure gracefully.

2012-03-19T15:11:43+00:00

Server send reply failure should not call server connection cleanup because
if a reconnection happens with in the grace-timeout the connection object is
reused. We must cleanup only on grace-timeout.

Change-Id: I7d171a863382646ff392031c2b845fe4f0d3d5dc
BUG: 803365
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2947
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client: Avoid STACK_DESTROYing more than once in RELEASE fops.

2012-03-19T12:58:30+00:00

Change-Id: I435327c6133aa6739731dabddde860b0b43c1497
BUG: 804607
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/2978
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System

print bound_xl only once in server statedump

2012-03-19T12:51:28+00:00

since, currently there is only one bound_xl for
all connection objects, it does not make sense
to print the bound_xl for every conn object.

Change-Id: Iaf4a170fe63fb7e80133c449a20f298f0e86364c
BUG: 765495
Signed-off-by: Rahul C S 
Reviewed-on: http://review.gluster.com/2975
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/quota : Fix timeout min value

2012-03-19T12:47:41+00:00

Change timeout min value to 0, so that default value of 0 successfully validates
and mounts happen properly.

Change-Id: I579c6192b97ffe2678fa95c912679b514fa7d8c0
BUG: 804509
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/2976
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

cluster/dht: Prevent crash in dir xattr selfheal

2012-03-19T12:46:52+00:00

Change-Id: I2ca4ab2f8e8611e7b2ac9ed2edc2e304727259dc
BUG: 804280
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.com/2970
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System

cluster/stripe: fix {set/get}xattr query for dirs/symlink

2012-03-18T09:19:29+00:00

This patch fixes the following problems:
* ENOENT returned for getxattr (xtime) on symlinks
    Non-data entities are created only on the first subvolume but
    getxattr fop winds to all subvols. This results in all subvols
    except the first one to return ENOENT which is propogated down
    the stack.

* ENODATA returned for getxattr (xtime) on directory
    setxattr calls always wind to the first stripe subvolume.
    xtime getxattr invocation winds to all subvolumes but the
    xattr is present in only the first one, resulting in all
    subvols except the first one to return ENODATA.

Fix

  For symlinks getxattr now always winds to the first subvol and
  for directories setxattr sets the xattr on all subvols.

NOTE

   For directories the all-subvol-wind in setxattr is done
   only when request is from a special client (client-pid == -1)

Change-Id: I9236345ef319506770d2034b840ee4ac04704b21
BUG: 801394
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.com/2948
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda 
Reviewed-by: Anand Avati

Logs: Improved logs in lock/unlock execution path

2012-03-18T08:53:41+00:00

Statedump will now start showing the lk-owner of the stack.

Change-Id: I9f650ce9a8b528cd626c8bb595c1bd1050462c86
BUG: 803209
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2968
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/client: replace STACK_UNWIND_STRICT macro with CLIENT_STACK_UNWIND,

2012-03-18T08:52:37+00:00

which does appropraite cleanup before unwinding.

Signed-off-by: Raghavendra G 
Change-Id: Ic49d6e21c5fc56e747afec35be2bebbbbd2a6583
BUG: 767359
Reviewed-on: http://review.gluster.com/2897
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati