glusterfs.git/xlators, branch bug-deprecated

feature/changelog: Logging entry as well for explicit sync virtual xattr.

2015-01-09T09:17:28+00:00

This is an improvement over the patch 'http://review.gluster.org/9337'
to trigger explicit geo-rep sync on regular files even if entry is not
present on the slave. An attempt is made to find the pargfid and
if available captures CREATE along with DATA in changelog.
CREATE is captured with default file permissions. Setting this virtual
setxattr on directories captures MKDIR in changelog. The value of
setxattr can be as follows.

If value = "1"       : Both CREATE and DATA is captured in changelog if
                       pargfid is available, else on DATA is captured.
   value = "any other: ENOTSUP is returned.

Usage:
  setfattr -n glusterfs.geo-rep.trigger-sync -v "1" 

NOTE: This patch supports explicit record of entries only for
      directories and regular files.

Change-Id: Iedde8b2c8bc3b78db524050d8c866ff664811d01
BUG: 1176934
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/9370
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Tested-by: Venky Shankar

cluster/ec: Handle internal xattr get/set

2015-01-09T05:55:37+00:00

Problem:
Internal xattrs of EC like trusted.ec.size/config/version
can be modified by users and that can lead to misbehavior
in EC.

Fix:
Don't let the user modify the xattrs. Hide these xattrs
in getfattr outputs.

Change-Id: I39cec96ae12826b506b496fda7da74201015fd75
BUG: 1178688
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9385
Tested-by: Gluster Build System 
Reviewed-by: Emmanuel Dreyfus 
Tested-by: Emmanuel Dreyfus 
Reviewed-by: Xavier Hernandez

cluster/ec: Do not modify quota, selinux xattrs in healing

2015-01-09T05:55:10+00:00

Problem:
EC heal tries to heal quota-size, selinux xattrs as well.  quota-size is
private to the brick but since quotad accesses them using the standard
interface as well, they can not be filtered in the fops.

Fix:
Ignore QUOTA_SIZE_KEY and SELINUX xattrs during heal.

Change-Id: I1572f9e2fcba7f120b4265e034953a15ff297f04
BUG: 1179640
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9401
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System

glusterd: use list_for_each_entry_safe for cleanup

2015-01-08T16:49:55+00:00

Use list_for_each_entry_safe() instead of
list_for_each_entry() for cleanup of local
xaction_peers list.

Change-Id: I6d70c04dfb90cbbcd8d9fc4155b8e5e7d7612460
BUG: 1173414
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/9416
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

glusterd: Refactor glusterd-utils.c

2015-01-08T13:32:11+00:00

Refactor glusterd-utils.c to create
glusterd-snapshot-utils.c consisting of all snapshot
utility functions.

Change-Id: Id9823a2aec9b115f9c040c9940f288d4fe753d9b
BUG: 1176770
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/9391
Reviewed-by: Kaushal M 
Reviewed-by: Rajesh Joseph 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

avoid memory leaks in snapview-server

2015-01-08T10:05:14+00:00

* snapview-server in readdirp, creates the inode for entries with names "." and
  ".." for each readdirp operation without creating dentries leading to memleak.
  It should have avoided creation of inodes for those entries

Change-Id: I3b2025fd10872fcc3303d0becec764ffd4e37601
BUG: 1179663
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/9404
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: cluster quorum count check correction

2015-01-06T13:44:38+00:00

Due to the recent change introduced by commit
da9deb54df91dedc51ebe165f3a0be646455cb5b cluster quorum count calucation now
depends on whether the peer list is either all peers or global transaction peer
list or the local transaction peer list.

Change-Id: I9f63af9a0cb3cfd6369b050247d0ef3ac93d760f
BUG: 1173414
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9350
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Avra Sengupta 
Reviewed-by: Kaushal M

libglusterfs: change signature of syncop_(f)getxattr

2015-01-06T06:00:09+00:00

Pass xdata dict to syncop_(f)getxattr calls.

This patch [1/3] is required as a part of afr automated split-brain resolution
implementation.

Change-Id: I3970b3dd6daf64681a031e37f8e9afb14fb3d668
BUG: 1136769
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/9375
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Vijay Bellur

cluster/afr: serialize inode locks

2015-01-05T03:51:43+00:00

Problem:
Afr winds inodelk calls without any order, so blocking inodelks
from two different mounts can lead to dead lock when mount1 gets
the lock on brick-1 and blocked on brick-2 where as mount2 gets
lock on brick-2 and blocked on brick-1

Fix:
Serialize the inodelks whether they are blocking inodelks or
non-blocking inodelks.

        Non-blocking locks also need to be serialized.
Otherwise there is a chance that both the mounts which issued same
non-blocking inodelk may endup not acquiring the lock on any-brick.
Ex:
Mount1 and Mount2 request for full length lock on file f1.  Mount1 afr may
acquire the partial lock on brick-1 and may not acquire the lock on brick-2
because Mount2 already got the lock on brick-2, vice versa. Since both the
mounts only got partial locks, afr treats them as failure in gaining the locks
and unwinds with EAGAIN errno.

Change-Id: Ie6cc3d564638ab3aad586f9a4064d81e42d52aef
BUG: 1176008
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9372
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

features/uss: Perform NULL check on @name in svc_getxattr

2015-01-02T13:10:12+00:00

LISTXATTR fop is internally converted into a GETXATTR with
the "name" parameter set to NULL. In svc_getxattr(), a listxattr
was causing a crash because of a NULL pointer dereference on @name.

FIX:
Add the necessary NULL check.

Change-Id: I70024d40dc0695648c6d41b423c2665d030e1232
BUG: 1178079
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9378
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Sachin Pandit 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur