glusterfs.git/xlators/system, branch v3.3.0qa30

system/posix-acl: fix reference counting in posix_acl_readdirp_cbk

2012-03-14T09:17:13+00:00

unref. the acl pointers from posix_acl_get()

Change-Id: I1247f64ceded17bfa204d1b899ec56a27bef0cdb
Signed-off-by: Brian Foster 
BUG: 801183
Reviewed-on: http://review.gluster.com/2904
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Amar Tumballi

system/posix-acl: fix acl inode assignment in posix_acl_readdirp_cbk

2012-03-14T09:16:36+00:00

If an entry includes no ACL returned via dictionary, it is possible
to skip down to acl_set without updating acl_access and/or
acl_default. If either are set from the previous iteration, the
unrelated ACLs are set to the current entry. Use a single set of
pointers to ensure that valid ACLs are always set.

Change-Id: Ia94887ded91845bc39d4d5e95ef00d190681e517
BUG: 801183
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.com/2903
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Amar Tumballi

core: add an extra flag to readv()/writev() API

2012-02-14T09:09:02+00:00

needed to implement a proper handling of open flag alterations
using fcntl() on fd.

Change-Id: Ic280d5db6f1dc0418d5c439abb8db1d3ac21ced0
Signed-off-by: Amar Tumballi 
BUG: 782265
Reviewed-on: http://review.gluster.com/2723
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: get xattrs also as part of readdirp

2012-01-25T10:03:44+00:00

readdirp_req() call sends a dict_t * as an argument, which
contains all the xattr keys for which the entries got in
readdirp_rsp() are having xattr value filled dictionary.

Change-Id: I8b7e1290740ea3e884e67d19156ce849227167c0
Signed-off-by: Amar Tumballi 
BUG: 765785
Reviewed-on: http://review.gluster.com/771
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

posix-acl: properly process umask in case client sent it

2012-01-12T17:12:38+00:00

FUSE used to interpret the umask itself. That was a bad idea, since
there are cases where umask is not applied, such as when extended POSIX
ACLs are present and default ACLs are set on parent directory.

The FUSE bridge was changed to send original mode with umask (alongside
masked mode, for compatibility). If that is the case, we decide whether
to apply the umask or not in the posix-acl translator depending on
whether a default umask is set, or not.

The original, broken, behavior is preserved in following cases:
* Unpatched client (not sending umask with original mode)
* Unpatched server (not understanding umask with original mode)
* Old FUSE on client side (FUSE < 7.12 or linux < 2.6.31)
  (can not find out the umask and original mode)

Change-Id: I2e3bfc4c7c9611bc51119ca5c8e28f6582677516
Signed-off-by: Lubomir Rintel 
Tested-by: Lubomir Rintel 
BUG: 765508
Reviewed-on: http://review.gluster.com/668
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

features/posix-acl: handle fini for features/posix-acl

2011-12-26T10:49:31+00:00

Signed-off-by: shishir gowda 
Change-Id: I6cd3a9c3a513cc2a998b82610613bbfa0622eec4
BUG: 767862
Reviewed-on: http://review.gluster.com/811
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

build: warning suppression (round n)

2011-10-20T11:13:50+00:00

with this patch, there are no more warnings with gcc (GCC) 4.6.1 20110908

Change-Id: Ice0d52d304b9846395f8a4a191c98eb53125f792
BUG: 2550
Reviewed-on: http://review.gluster.com/607
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

posix-acl: configurable super user ID

2011-09-08T14:08:13+00:00

In configurations with a uid mapper, super user ID could be mapped
to a non-zero value. Hence making it configurable in access control
would be necessary for proper super-user semantics.

Change-Id: I51e8e0395680e9b96a99657a0af547659bd9affe
BUG: 2815
Reviewed-on: http://review.gluster.com/332
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Save the mode flags set by the application when ACLs are in use

2011-09-08T07:20:21+00:00

While inheriting the ACLs from a directory that has default ACLs, make sure
that the mode flags set by the application are saved. It is required to
inherit only the Read, Write and Execute permissions while leaving the others
viz. setuid, setgid and sticky bit untouched hence honouring the requests made
by the application during create operations (mknod, mkdir et al).

For a description of the problem, root cause and evaluation, refer:
http://bugs.gluster.com/show_bug.cgi?id=3522

Change-Id: I994077fb321a35d8254f0cc5a7de99a17ec40c47
BUG: 3522
Reviewed-on: http://review.gluster.com/368
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Eliminate many "var set but not used" warnings with newer gcc.

2011-09-08T06:48:01+00:00

This fixes ~200 such warnings, but leaves three categories untouched.

(1) Rpcgen code.

(2) Macros which set variables in the outer (calling function) scope.

(3) Variables which are set via function calls which may have side effects.

Change-Id: I6554555f78ed26134251504b038da7e94adacbcd
BUG: 2550
Reviewed-on: http://review.gluster.com/371
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati