glusterfs.git/xlators/system/posix-acl/src/posix-acl.c, branch v3.4.0beta3

posix-acl: fetch ACLs in readdirplus

2013-06-08T21:49:27+00:00

Not fetching ACLs in readdirplus can potentially result in spurious
wrong ACL decisions (which magically go away on a lookup() which
populates the ACLs)

Change-Id: Ided38b4d868fab482b477ce51b4878289ef9eed0
BUG: 953694
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5156
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

system/posix-acl: prevent NULL pointer dereference of group_ce

2012-12-27T07:03:06+00:00

Thanks Amar Tumballi.

Change-Id: I3ac9b46d4c3fcd12d1eec779317a03c47d267556
BUG: 887098
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/4351
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

All: License message change

2012-09-13T20:19:37+00:00

License message changed for server-side, dual license GPLV2 and LGPLv3+.

Change-Id: Ia9e53061b9d2df3b3ef3bc9778dceff77db46a09
BUG: 852318
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3940
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati

License change to 2 additional files.

2012-09-05T14:50:28+00:00

Change-Id: I4689602cbea0e46498d10b8785bcde86d369e75d
BUG: 852318
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3880
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

posix-acl: make use of 'umask' flag passed as argument in fop

2012-08-23T08:02:43+00:00

* currently "umask" is reffered only from xdata dictionary, instead
  we should utilize fop argument.
* not taking of setting of "umask" in fuse for now, considering the
  backward compatibility with earlier releases.
* dict_del() the "umask" and "mode" keys from xdata dict as the fop
  after reaching posix layer tries to set every entry in xdata as
  xattr on file/dir.

Change-Id: I7199b05a5bde132df20e7812a99bc02ef7b988ce
Signed-off-by: Amar Tumballi 
BUG: 850873
Reviewed-on: http://review.gluster.org/3843
Tested-by: Gluster Build System 
Reviewed-by: Brian Foster 
Reviewed-by: Anand Avati

acl: enable handling of FMODE_EXEC flag

2012-07-28T04:39:08+00:00

on linux systems, with open(), we can get below flag as per
'linux/fs.h'.

/* File is opened for execution with sys_execve / sys_uselib */

Instead of adding '#include , its better to copy this
absolute number into other variable because then we have to deal
with declaring fmode_t etc etc..

With the fix, we can handle the file with '0711' permissions in
the same way as backend linux filesystems.

Change-Id: Ib1097fc0d2502af89c92d561eb4123cba15713f5
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.com/3739
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Tested-by: Niels de Vos 
Reviewed-by: Anand Avati

remove useless if-before-free (and free-like) functions

2012-07-13T21:03:42+00:00

See comments in http://bugzilla.redhat.com/839925 for
the code to perform this change.

Signed-off-by: Jim Meyering 
BUG: 839925
Change-Id: I10e4ecff16c3749fe17c2831c516737e08a3205a
Reviewed-on: http://review.gluster.com/3661
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: adding extra data for fops

2012-03-22T23:40:27+00:00

with this change, the xlator APIs will have a dictionary as extra
argument, which is passed between all the layers. This can be
utilized for overloading in some of the operations.

Change-Id: I58a8186b3ef647650280e63f3e5e9b9de7827b40
Signed-off-by: Amar Tumballi 
BUG: 782265
Reviewed-on: http://review.gluster.com/2960
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

system/posix-acl: fix reference counting in posix_acl_readdirp_cbk

2012-03-14T09:17:13+00:00

unref. the acl pointers from posix_acl_get()

Change-Id: I1247f64ceded17bfa204d1b899ec56a27bef0cdb
Signed-off-by: Brian Foster 
BUG: 801183
Reviewed-on: http://review.gluster.com/2904
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Amar Tumballi

system/posix-acl: fix acl inode assignment in posix_acl_readdirp_cbk

2012-03-14T09:16:36+00:00

If an entry includes no ACL returned via dictionary, it is possible
to skip down to acl_set without updating acl_access and/or
acl_default. If either are set from the previous iteration, the
unrelated ACLs are set to the current entry. Use a single set of
pointers to ensure that valid ACLs are always set.

Change-Id: Ia94887ded91845bc39d4d5e95ef00d190681e517
BUG: 801183
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.com/2903
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Amar Tumballi