glusterfs.git/xlators/storage, branch v3.7.2

storage/posix: Handle MAKE_INODE_HANDLE failures

2015-06-16T08:30:32+00:00

        Backport of http://review.gluster.com/11028

BUG: 1221473
Change-Id: Iefa2a9037e7a415e55581054b16c840bae56561e
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11167
Tested-by: Gluster Build System 
Reviewed-by: Krutika Dhananjay 
Tested-by: NetBSD Build System

cluster/dht: Fix dht_setxattr to follow files under migration

2015-06-04T12:03:59+00:00

If a file is under migration, then any xattrs created on it
are lost post migration of the file. This is because
the xattrs are set only on the cached subvol of the source
and as the source is under migration, it becomes a linkto file
post migration.

Change-Id: Ib8e233b519cf954e7723c6e26b38fa8f9b8c85c0
BUG: 1225839
Signed-off-by: Nithya Balachandran 
Reviewed-on: http://review.gluster.org/10968
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

gfapi: zero size issue in glfs_h_acl_set()

2015-06-01T09:20:23+00:00

When setting the stringified ACLs in the xattr dict through
pub_glfs_h_setxattrs(), the size of the string is always passed as 0.
The correct way is to pass the length of the ACL in text form.

Backport of:
> Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34
> BUG: 789278
> Reviewd-on: http://review.gluster.org/10782
> Signed-off-by: Jiffin Tony Thottan 

Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34
BUG: 1224241
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10890
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

posix: Do not update unmodified xattr in (f)xattrop

2015-05-29T05:54:34+00:00

        Backport of http://review.gluster.org/10886

If a (f)xattrop is issued with a value that only contains 0's,
then we don't modify or create the extended attribute. This
is useful to avoid ctime modifications when the only purpose
of the xattrop was to get the current value.

Change-Id: Ia62494e9009962e683c8276783f671da17a8b03a
BUG: 1225320
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/10928
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

features/trash : Notify CTR translator if an unlink happens to a file

2015-05-05T06:21:06+00:00

        Backport of http://review.gluster.org/#/c/9989/

This implementation is same as the posix_unlink_cbk() where CTR sends
a request during a unlink to send the number of links to the inode
and posix obliges sending it using the unwind xdata dict.
For Trash xlator a unlink is stat + mkdir(if parent is not present)
+ rename. And hence this is handled in trash_unlink_rename_cbk().

Change-Id: I402e83567b88e3c9fe171379693c82937af567f9
BUG: 1218032
Signed-off-by: Jiffin Tony Thottan 
Signed-off-by: Joseph Fernandes 
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/10513
Reviewed-by: Joseph Fernandes
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Vijay Bellur

storage/posix: prevent NULL dereference

2015-05-02T09:39:37+00:00

        Backport of http://review.gluster.org/10383

filler->fd is never set but used.

BUG: 1216303
Change-Id: I02dc346c526be5af4ea55ae13e8314316f127455
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/10437
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur

storage/posix: Introduce xattr-fill on fds

2015-04-13T06:32:22+00:00

... with some of the code borrowed from http://review.gluster.org/#/c/3904/

Change-Id: I4901ef14d6f843d8d69f102d43d21b60ba298092
BUG: 1207603
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/10180
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

bitrot/scrub: Scrubber fixes

2015-04-08T07:01:32+00:00

This patch fixes a handful of problem with scrubber which
are detailed below.

Scrubber used to skip objects for verification due to missing
fd iterface to fetch versioning extended attributes. Similar
to the inode interface, an fd based interface in POSIX is now
introduced.

Moreover, this patch also fixes potential false reporting by
scrubber due to:

  An object gets dirtied and signed when scrubber is busy
  calculatingobject checksum. This is fixed by caching the
  signed version when an object is first inspected for
  stalenes, i.e., during pre-compute stage. This version is
  used to verify checksum in the post-compute stage when the
  signatures are compared for possible corruption.

  Side effect of _not_ sending signature length during signing
  resulted in "truncated" signature to be set for an object.
  Now, at the time of signing, the signature length is sent
  and is used in place of invoking strlen() to get signature
  length (which could have possible 00s). The signature length
  itself is not persisted in the signature xattr, but is
  calculated on-the-fly by substracting the xattr length by
  the "structure" header size.

Some of the log entries are made more meaningful (as and aid
for debugging).

Change-Id: I938bee5aea6688d5d99eb2640053613af86d6269
BUG: 1207624
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10118
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/bitrot-stub: Enhancement to versioning protocol

2015-04-08T06:43:09+00:00

.. and potential bug fixes / memleak.

While assigning initial version to an object, both extended attributes
(namely, ongoing version and the default signing version) were persisted.
This is optimized to just persist the ongoing version along with safe
handling of xattr request(s) in it's absence. This is better than the
earlier approach as the two xattr sets were not atomic anyway (allowing
a request to sneak in between between two set operations). This also
allows to perform sanity checks on objects during lookup()/getxattr():
objects with missing ongoing version but presence of signature are
possible candidates of tampering (and catching implementation bugs).

There were couple of instances in the code where versioning xattrs
were incorrectly removed before in-memory versions were initialized,
which have been fixed with this patch. A memory leak in the IPC code
path is also fixed.

Change-Id: I01c690ccfe7156a883582275f40f79a7c10c0900
BUG: 1207054
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10117
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

storage/posix: Introduce xattr_fill capability in posix_stat

2015-04-08T06:09:54+00:00

Change-Id: I2b6503ad9333f445ebdcd9fa660da20b861b985f
BUG: 1207603
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/10158
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri