glusterfs.git/xlators/storage, branch v3.7.0alpha0

storage/posix: Introduce xattr-fill on fds

2015-04-13T06:32:22+00:00

... with some of the code borrowed from http://review.gluster.org/#/c/3904/

Change-Id: I4901ef14d6f843d8d69f102d43d21b60ba298092
BUG: 1207603
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/10180
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

bitrot/scrub: Scrubber fixes

2015-04-08T07:01:32+00:00

This patch fixes a handful of problem with scrubber which
are detailed below.

Scrubber used to skip objects for verification due to missing
fd iterface to fetch versioning extended attributes. Similar
to the inode interface, an fd based interface in POSIX is now
introduced.

Moreover, this patch also fixes potential false reporting by
scrubber due to:

  An object gets dirtied and signed when scrubber is busy
  calculatingobject checksum. This is fixed by caching the
  signed version when an object is first inspected for
  stalenes, i.e., during pre-compute stage. This version is
  used to verify checksum in the post-compute stage when the
  signatures are compared for possible corruption.

  Side effect of _not_ sending signature length during signing
  resulted in "truncated" signature to be set for an object.
  Now, at the time of signing, the signature length is sent
  and is used in place of invoking strlen() to get signature
  length (which could have possible 00s). The signature length
  itself is not persisted in the signature xattr, but is
  calculated on-the-fly by substracting the xattr length by
  the "structure" header size.

Some of the log entries are made more meaningful (as and aid
for debugging).

Change-Id: I938bee5aea6688d5d99eb2640053613af86d6269
BUG: 1207624
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10118
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/bitrot-stub: Enhancement to versioning protocol

2015-04-08T06:43:09+00:00

.. and potential bug fixes / memleak.

While assigning initial version to an object, both extended attributes
(namely, ongoing version and the default signing version) were persisted.
This is optimized to just persist the ongoing version along with safe
handling of xattr request(s) in it's absence. This is better than the
earlier approach as the two xattr sets were not atomic anyway (allowing
a request to sneak in between between two set operations). This also
allows to perform sanity checks on objects during lookup()/getxattr():
objects with missing ongoing version but presence of signature are
possible candidates of tampering (and catching implementation bugs).

There were couple of instances in the code where versioning xattrs
were incorrectly removed before in-memory versions were initialized,
which have been fixed with this patch. A memory leak in the IPC code
path is also fixed.

Change-Id: I01c690ccfe7156a883582275f40f79a7c10c0900
BUG: 1207054
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10117
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

storage/posix: Introduce xattr_fill capability in posix_stat

2015-04-08T06:09:54+00:00

Change-Id: I2b6503ad9333f445ebdcd9fa660da20b861b985f
BUG: 1207603
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/10158
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri

Avoid conflict between contrib/uuid and system uuid

2015-04-04T17:48:35+00:00

glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.

Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.

A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.

BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

Xlators : Fixed typos

2015-04-02T10:21:08+00:00

Change-Id: I948f85cb369206ee8ce8b8cd5e48cae9adb971c9
BUG: 1075417
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/9529
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Humble Devassy Chirammal

bd: coverity fixes, removing logically dead code and correcting checks

2015-03-30T07:42:49+00:00

Coverity CIDs:
    1128910
    1128911
    1128913
    1128912
    1134020

Change-Id: I2d871723fbfe43f9ff6b3beba7a99b0d81d4aff5
BUG: 789278
Signed-off-by: Nandaja Varma 
Reviewed-on: http://review.gluster.org/9588
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

bd: Fixing dereference after null check(FORWARD_NULL)

2015-03-30T07:33:49+00:00

CID: 1128907
The pointer variable 'bdatt' redirected to a goto label
when the value was NULL and in the other condition when it is not NULL
, hence the bdatt is again checked for NULL at 'reverse xattr' label.

Change-Id: I2289cbf30fde9faf97e6eebd4902953a44049f9e
BUG: 789278
Signed-off-by: arao 
Reviewed-on: http://review.gluster.org/9619
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

posix : unchecked return value coverity fix.

2015-03-30T06:54:24+00:00

CID   : 1124364

Change-Id: I1e16e3ff46b191ba2ea527e628c77a99a56f6c31
BUG: 789278
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/9667
Reviewed-by: Niels de Vos 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

posix: handle failure from posix_resolve

2015-03-25T16:11:34+00:00

When building ancestory, posix_resolve gets the inode
from the gfid. We need to handle the failure case from
this function

Change-Id: I19f0f0c739686b1b0ef96309212aa1c7911b3589
BUG: 1203629
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9941
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri