glusterfs.git/xlators/storage, branch v3.5.1

protocol/server: send ENOENT instead of ESTALE for older clients

2014-06-20T09:45:54+00:00

Modify protocol/server and storage/posix to send ENOENT to older clients
instead of ESTALE

http://goo.gl/t83hmL

Change-Id: Ie63e91e73e33769ce9dc3d964938cfd6eb4c4be5
BUG: 1109832
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/8080
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/marker-quota: more stringent error handling in rename.

2014-05-11T02:36:10+00:00

If an error occurs and op_errno is not set to non-zero value, we can
end up in loosing a frame resulting in a hung syscall. This patch
adds code setting op_errno appropriately in storage/posix and
makes marker to set err to a default non-zero value in case of
op_errno being zero.

Change-Id: Idc2c3e843b932709a69b32ba67deb284547168f2
BUG: 833586
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6913
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

posix: if brick-uid or brick-gid is not specified, do not set

2014-05-09T14:36:02+00:00

Current code would set owner uid/gid explicitly to 0/0 on start
even if none was specified. Fix it.

Cherry picked from commit 8bdc329:
> Change-Id: I72dec9e79c51bd1eb3af5334c42b7c23b01d0258
> BUG: 1040275
> Signed-off-by: Anand Avati 
> Reviewed-on: http://review.gluster.org/6476
> Tested-by: Gluster Build System 
> Tested-by: Lukáš Bezdička 
> Reviewed-by: Krishnan Parthasarathi 
> Reviewed-by: Vijay Bellur 

Change-Id: Ie0396c1a4e6e0979ea9c855d33db963544a75c42
BUG: 1095971
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/7720
Tested-by: Gluster Build System

storage/posix: lgetxattr called with invalid keys on the bricks

2014-05-05T20:35:14+00:00

More invalid keys have crept in since this was fixed. We need a better
strategy for avoiding this than the current noticed-in-an-strace..

Cleaned tabs while I'm at it.

Change-Id: I0d5d3dd925cc626d06768b022ea0a572a9ea7e06
BUG: 765202
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/7004
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

storage/posix: do not dereference gfid symlinks before posix_handle_mkdir_hashes()

2014-05-05T13:38:03+00:00

Whenever a new directory is created, its corresponding gfid file must
also be created. This was done first calling MAKE_HANDLE_PATH() to get
the path of the gfid file, then calling posix_handle_mkdir_hashes() to
create the parent directories of the gfid, and finally creating the
soft-link.

In normal circumstances, the gfid we want to create won't exist and
MAKE_HANDLE_PATH() will return a simple path to the new gfid. However if
the volume is damaged and a self-heal is running, it is possible that we
try to create an already existing gfid. In this case, MAKE_HANDLE_PATH()
will return a path to the directory instead of the path to the gfid.

To solve this problem, every time a path to a gfid is needed, a call to
MAKE_HANDLE_ABSPATH() is made instead of the call to MAKE_HANDLE_PATH().

BUG: 859581
Change-Id: I84405bf04562e647fc02445f45358e9451f9b479
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/6736
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Niels de Vos

storage/posix: add list xattr capability to lookup

2014-04-28T16:53:35+00:00

BUG: 1078061
Change-Id: Ib84f40c84e2d66c86b1cec4a7cceb5aea189ba4a
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/7434
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez 
Reviewed-by: Ravishankar N 
Reviewed-by: Vijay Bellur

storage/posix: perform chmod after chown.

2014-02-17T09:51:03+00:00

Problem:
When a replica brick is added to a volume, set-user-ID and set-group-ID
permission bits of files are not set correctly in the new brick. The issue
is in the posix_setattr() call where we do a chmod followed by a chown.

But according to the man pages for chown:
When the owner or group of an executable file are changed by an unprivileged
user the S_ISUID and S_ISGID mode bits are cleared.  POSIX does not specify
whether this also  should  happen  when  root does the chown().

Fix:
Swap the chmod and chown calls in posix_setattr()

BUG: 1058797
Change-Id: Id2fbd8394cf6faf669f414775409f20f46009f2b
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/6988
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

POSIX : gefattr fails and mount point become inaccessible

2014-02-07T10:45:21+00:00

Problem : getfattr fails and mount point becomes inaccessible while
fetching glusterfs.ancestry.path key value for a gfid from aux-gfid-mount based mount point.

Analysis : The caller of posix_make_ancestryfromgfid() function i.e.
posix_get_ancestry_non_directory() is sending an incorrect type value as
an argument leading to a crash in posix_make_ancestral_node() (head
dirent pointer is NULL and an attempt to dereference causes seg fault).
For a non directory operation this piece of code should not have been
executed but due to incorrect type value this happened.

Solution : In posix_make_ancestryfromgfid() call type is passed as
logical or of type and POSIX_ANCESTRY_PATH instead of logical or of
POSIX_ANCESTRY_PATH and POSX_ANCESTRY_DENTRY.

Please note this patch is backport picked up from following patch:
http://review.gluster.org/#/c/6892/

Change-Id: Iaf844bea91396c5e2ee295d5a082998fda66f0a9
BUG: 1060104
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/6892
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6921

features/quota: remove in-memory accounting of files in enforcer

2014-01-28T16:47:26+00:00

Accounting was done in enforcer (though marker is the ultimate source
of truth) to offset cached directory size becoming stale. However,
with enforcer being moved to brick we can no longer maintain correct
cluster wide size for a directory. Hence removing accounting code from
enforcer.

Change-Id: I5ea94234da4da85ed5f5ced1354d8de3454b3fcb
BUG: 969461
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6434
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6818

bd: Check for capabilities for creating thin lv

2014-01-02T00:54:59+00:00

Check capabitlies of the volume before trying to create thin LV.

BUG: 1028672

Change-Id: Ie4e2281265e193458ccd16736960daf69d3e1b29
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/6590
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System