glusterfs.git/xlators/storage, branch v3.4.1

build: declare lvm_lv_from_name() if it is missing from lvm2app.h

2013-06-27T12:39:43+00:00

The bd-xlator can not be built successfully on certain Debian
distributions due to a missing declaration of lvm_lv_from_name(). This
function is available for linking, but it does not exist in the header
file.

This change adds a detection for lvm_lv_from_name() in both the library
for linking, and the declaration in the header file. If the 1st is
missing, the bd-xlator can not be built, and if only the 2nd one is
missing, we'll declare lvm_lv_from_name() ourselves. This makes it
possible to build the bd-xlator on the affected Debian distributions
too.

Change-Id: If1845f6b6d676793677ebbcc6daf9ff12f7c3fd6
BUG: 976946
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/5260
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

dht,posix: support for case discovery

2013-06-08T21:51:22+00:00

This is support for discovering a filename in a given directory
which has a case insensitive match of a given name. It is implemented
as a virtual extended attribute on the directory where the required
filename is specified in the key.

E.g:

  sh# getfattr -e "text" -n user.glusterfs.get_real_filename:FiLe-B /mnt/samba/patchy
  getfattr: Removing leading '/' from absolute path names
  # file: mnt/samba/patchy
  user.glusterfs.get_real_filename:FiLe-B="file-b"

In reality, there can be multiple "answers" as the backend filesystem is
case sensitive and there can be multiple files which can strcasecamp()
successfully. In this case we pick the first matched file from the first
responding server.

If a matching file does not exist, we return ENOENT (and NOT ENODATA).
This way the caller can differentiate between "unsupported" glusterfs
API and file not existing.

This API is used by Samba VFS to perform efficient discovery of the real
filename without doing a full scan at the Samba level.

Change-Id: I53054c4067cba69e585fd0bbce004495bc6e39e8
BUG: 953694
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5163
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

posix: fix dangerous "sharing" of fd in readdir between two requests

2013-05-07T18:54:33+00:00

posix_fill_readdir() is a multi-step function which performs many
readdir() calls, and expects the directory cursor to have not
"seeked away" elsewhere between two successive iterations. Usually
this is not a problem as each opendir() from an application has its
own backend fd, and there is nobody else to "seek away" the directory
cursor. However in case of NFS's use of anonymous fd, the same fd_t
is shared between all NFS readdir requests, and two readdir loops can
be executing in parallel on the same dir dragging away the cursor in
a chaotic manner.

The fix in this patch is to lock on the fd around the loop. Another
approach could be to reimplement posix_fill_readdir() with a single
getdents() call, but that's for another day.

Change-Id: Ia42e9c7fbcde43af4c0d08c20cc0f7419b98bd3f
BUG: 948086
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/4774
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Reviewed-on: http://review.gluster.org/4963

storage/posix: honor O_SYNC and O_DSYNC sent in @flags of writev()

2013-05-07T18:02:10+00:00

Historic bug - posix_writev() has been inspecting pfd->flushwrites for
performing fsync() after write, instead of @flags for O_SYNC|O_DSYNC.

pfd->flushwrites was never set anywhere and is unused completely. This
is behavior from the time before anonymous FD where open() had @wbflags
param. This is a leftover from that cleanup.

Change-Id: Id9bfe562a60db4eb3bd0a7705bdba91f2df2f3ec
BUG: 916372
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/4738
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-on: http://review.gluster.org/4962

Use proper libtool option -avoid-version instead of bogus -avoidversion

2013-02-07T23:12:56+00:00

Change-Id: I1c9541058c7d07786539a3266ca125a6a15287d8
BUG: 859835
Signed-off-by: Anand Avati 
Original-author: Kacper Kowalik (Xarthisius) 
Signed-off-by: Kacper Kowalik (Xarthisius) 
Reviewed-on: http://review.gluster.org/3967
Tested-by: Gluster Build System

storage/posix: Fix open-fd-count virtual xattr

2013-02-06T17:49:21+00:00

Send open-fd-count maintained in inode.

Change-Id: I23db5d052bdeb4f67978ff618ed5a0bed7d1592d
BUG: 908146
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4469
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

storage/posix: skip path construction when dentry list is empty

2013-01-26T19:37:04+00:00

This is a minor latency optimization to the readdirp path in
storage/posix. During a recursive list, we hit this codepath with
an empty list once per high-level directory to read when end of
directory is reached. Skip constructing hpath, since we don't do
anything with it in this case.

BUG: 903175
Change-Id: I98d7c65505205d55575f064b1e982700f1320cc0
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4432
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: fix descriptions of owner-uid and owner-gid

2013-01-21T18:06:34+00:00

Change-Id: I04c0dd23bc5bc34fd9d7bddb11beeecb8e7e2a49
BUG: 853842
Signed-off-by: Shireesh Anjal 
Reviewed-on: http://review.gluster.org/4398
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

Fix format security errors with hardening build flags

2013-01-17T01:44:43+00:00

These problems were found while building with the hardening options used
by Debian. In order to prevent introducing new unsafe constructs, the
options -Wformat" and -Werror=format-security are addeded to the CFLAGS
by configure.ac if the compiler supports them.

Also, a small spelling fix in posix-aio.c is included.

Change-Id: I1034311644fa3c21bc5a7b842c41a3ca79108b3f
BUG: 887278
Original-author: Patrick Matthäi 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/4311
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati

core: remove all the 'inner' functions in codebase

2012-12-20T07:35:29+00:00

* move 'dict_keys_join()' from api/glfs_fops.c to libglusterfs/dict.c
  - also added an argument which is treated as a filter function if
    required, currently useful for fuse.

* now 'make CFLAGS="-std=gnu99 -pedantic" 2>&1 | grep nested' gives
  no output.

Change-Id: I4e18496fbd93ae1d3942026ef4931889cba015e8
Signed-off-by: Amar Tumballi 
BUG: 875913
Reviewed-on: http://review.gluster.org/4187
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati