glusterfs.git/xlators/storage, branch testing-regression-job

storage/posix: Remove nr_files usage

2019-03-14T04:47:47+00:00

nr_files is supposed to represent the number of files opened in posix.
Present logic doesn't seem to handle anon-fds because of which the
counts would always be wrong.

I don't remember anyone using this value in debugging any problem probably
because we always have 'ls -l /proc//fd' which not only prints the
fds that are active but also prints their paths. It also handles directories
and anon-fds which actually opened the file. So removing this code
instead of fixing the buggy logic to have the nr_files.

fixes bz#1688106
Change-Id: Ibf8713fdfdc1ef094e08e6818152637206a54040
Signed-off-by: Pranith Kumar K

storage/posix: print the actual file path

2019-02-14T08:28:59+00:00

posix converts incoming operations on files to operations on
corresponding gfid handles. While this in itself is not a problem,
logging of those gfid handles in place of actual file paths can
create confusions during debugging. The best way would be to
print both the actual file (recieved as an argument) for path
based operations and the gfid handle associated with it.

Change-Id: I408c36ca6456f2e3981b93151c19ef7f60085ad6
fixes: bz#1675076
Signed-off-by: Raghavendra Bhat

afr/self-heal:Fix wrong type checking

2019-01-24T12:16:50+00:00

gf_dirent struct has d_type variable which should check
with DT_DIR istead of IA_IFDIR or IA_IFDIR has to compare
with entry->d_stat.ia_type

Change-Id: Idf1059ce2a590734bc5b6adaad73604d9a708804
updates: bz#1653359
Signed-off-by: Mohammed Rafi KC

posix: Change data type to dump nr_files to statedump

2019-01-23T03:16:08+00:00

Problem: In commit 2261e444a47ffffb5d64305efceee1d5a734cd75
         wrong data type of nr_files was changed to dump
         nr_files to statedump so build is failing on 32bit
         environment

Solution: Change data type to avoid errors

Change-Id: Ifb4b19feda6e0e56d110b23351e7a0efd5bfa29b
fixes: bz#1657607
Signed-off-by: Mohit Agrawal

posix: fix coverity issue

2019-01-21T04:26:37+00:00

Logically dead code

CID: 1398468
Updates: bz#789278

Change-Id: I8713a0c51777eb64e617d00ab72fd1db4994b6ab
Signed-off-by: Iraj Jamali

posix: Convert several posix_private members to gf_atomic

2019-01-15T11:52:22+00:00

Change-Id: I629698d8ddf6f15428880bdc1501d36bc37b8ebb
fixes: bz#1657607
Signed-off-by: Mohit Agrawal

fix 32-bit-build-smoke warnings

2019-01-11T18:25:18+00:00

fixes: bz#1622665

Change-Id: I777d67b1b62c284c62a02277238ad7538eef001e
Signed-off-by: Iraj Jamali

core: brick process is crashed at the time of spawn thread

2019-01-11T06:02:52+00:00

Problem: brick is getting crashed at the time of calling
         pthread_detach after just call gf_thread_create.If
         sufficient resources are not available on the system
         pthread_create returns EAGAIN (non-negative) but the
         caller function expects negative error code in case of failure

Solution: Change the condition in caller function to avoid the crash

Change-Id: Ifeaa49f809957eb6c33aa9792f5af1b55566756d
fixes: bz#1662906

posix: buffer_size_warning coverity fix

2018-12-31T06:49:15+00:00

Defect: CID 1398469- Calling strncpy with a maximum size argument
of 4096 bytes on destination array key of size 4096 bytes might
leave the destination string unterminated.

Fix: Using snprintf instead of strncpy.

updates: bz#789278

Change-Id: I4fdcd0cbf3af8b2ded94603d92d1ceb4112284c4
Signed-off-by: Harpreet Kaur

posix: stack-buffer-overflow reported by asan

2018-12-26T02:17:16+00:00

This patch fixes buffer overflow in
$SRC/xlators/storage/posix/src/posix-inode-fd-ops.c
Memory access at offset 432 overflows "md5_checksum" variable.
SUMMARY: AddressSanitizer: stack-buffer-overflow (/lib64/libasan.so.5+0xb825a)

updates: bz#1633930

Change-Id: I46010a09161d02cdf0c69679a334ec1d3d49cffb
Signed-off-by: Harpreet Kaur