glusterfs.git/xlators/storage/posix, branch bug-deprecated

telldir()/seekdir() portability fixes

2014-12-17T11:48:22+00:00

POSIX says that an offset obtained from telldir() can only be used
on the same DIR *. Linux is abls to reuse the offset accross
closedir()/opendir() for a given directory, but this is not portable
and such a behavior should be fixed.

An incomplete fix for the posix xlator was merged in
http://review.gluster.com/8926
This change set completes it.

- Perform the same fix index xlator.
- Use appropriate casts and variable types so that 32 bit signed
  offsets obtained by telldir() do not get clobbered when copied into
  64 bit signed types.
- modify glfs-heal.c and afr-self-heald.c so that they do not use
  anonymous fd, since this will cause closedir()/opendir() between
  each syncop_readdir(). On failure we fallback to anonymous fs
  only for Linux so that we can cope with updated client vs not
  updated brick.
- Avoid sending an EINVAL when the client request for the EOF offset.
  Here we fix an error in previous fix for posix xlator: since we
  fill each directory entry with the offset of the next entry, we
  must consider as EOF the offset of the last entry, and not the
  value of telldir() after we read it.
- Add checks in regression tests that we do not hit cases where
  offsets fed to seekdir() are wrong. Introduce log_newer() shell
  function to check for messages produced by the current script.

This fix gather changes from http://review.gluster.org/9047
and http://review.gluster.org/8936 making them obsolete.

BUG: 1129939
Change-Id: I59fb7f06a872c4f98987105792d648141c258c6a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/9071
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

storage/posix: Set errno for xattrop failures

2014-12-10T18:10:50+00:00

Change-Id: I4d44068c8da5257227d62906ec18ae16f6ed6c02
BUG: 1172477
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9261
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

Glusterfs/posix: Stack corruption in posix_handle_pump

2014-12-04T06:12:09+00:00

posix_handle_pump can corrupt the stack if the buffer
passed to it is too small to hold the final path.

Fix :
Check if the buffer is sufficiently large to hold the new path
component before modifying it. This will prevent the buffer
overrun but the path returned will most likely have too many symbolic
links causing subsequent file ops to fail with ELOOP.

The callers of this function do not currently check the return value.
The code needs to be modified to have all callers check the return
value and take appropriate action in case of an error.

Change-Id: I6d9589195a4b0d971a107514ded6e97381e5982e
BUG: 1113960
Signed-off-by: Nithya Balachandran 
Reviewed-on: http://review.gluster.org/8189
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri

posix: remove duplicate dirfd calls in posix_opendir

2014-12-01T05:41:49+00:00

BUG: 1168910
Change-Id: I285d352d20374bb3edee2db42d062d4724198425
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9186
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

posix: Fix buffer overrun in _handle_list_xattr()

2014-11-28T16:33:44+00:00

In _handle_list_xattr() we test remaining_size > 0 to check that
we do not overrun the buffer, but since that variable was unsigned
(size_t), the condition would let us go beyond end of buffer if
remaining_size became negative.

This could happen if attribute list grew between the first
sys_llistxattr() call that gets the size and the second sys_llistxattr()
call that get the data. We fix the problem by making remaining_size
signed (ssize_t). This also matches sys_llistxattr() return type.

While there, we use the size returned by the second sys_llistxattr()
call to parse the buffser, as it may also be smaller than the size
obtained from first call, if attribute list shrank.

This fixes a spurious crash in tests/basic/afr/resolve.t

BUG: 1129939
Change-Id: Ifc5884dd0f39a50bf88aa51fefca8e2fa22ea913
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/9204
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Vijay Bellur

posix: Changed order of chown and chmod

2014-11-14T09:43:07+00:00

    Problem:
    Rebalance process runs in the root mode. If a normal
    user create a file and if it  requires migration then
    because the migrated file is created by root, its owner and
    mode should  be changed to the source normal user and
    permission should be changed the previous mode. If
    the suid bit is also set, then at the destination
    suid bit should also be set.

    Two operations are performed in the given order:
    1. chmod
    2. chown

    But chown resets the suid bit. So changed the order
    of these two operations so that first chown will be
    performed and then chmod will be performd so that
    suid bit will be preserved.

Change-Id: Ib63b5cf528f8336b69bf090ad43bb02eec1d1602
BUG: 1086228
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: http://review.gluster.org/7435
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

inode: Handle '/' in basename in inode_link/unlink

2014-11-07T17:42:28+00:00

Problem:
inode_link is sometimes called with a trailing '/'. Lookup, dentry
operations like link/unlink/mkdir/rmdir/rename etc come without trailing
'/' so the stale dentry with '/' remains in the dentry list of the inode.

Fix:
Add assert checks and return NULL for '/' in bname.
Fix ancestry building code to call without '/' at the end.

Change-Id: I9c71292a3ac27754538a4e75e53290e182968fad
BUG: 1158751
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9004
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

storage/posix: Treat ENODATA/ENOATTR as success in bulk removexattr

2014-11-06T05:42:52+00:00

Bulk remove xattr is internal fop in gluster. Some of the xattrs may have
special behavior. Ex: removexattr("posix.system_acl_access"), removes more than
one xattr on the file that could be present in the bulk-removal request.
Removexattr of these deleted xattrs will fail with either ENODATA/ENOATTR.
Since all this fop cares is removal of the xattrs in bulk-remove request and
if they are already deleted, it can be treated as success.

Change-Id: Id8f2a39b68ab763ec8b04cb71b47977647f22da4
BUG: 1160509
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9049
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Avoid spurious EINVAL in posix_readdir()

2014-10-29T09:26:32+00:00

On non Linux systems, we check that seekdir() succeeds and we return
EINVAL if it does not. We need this to avoid infinite loops if some
other component in GlusterFS makes an invalid seekdir() usage. This
was introduced in this change: http://review.gluster.org/#/c/8760/

But seekdir() also fails when using the offset returned for the
last entry, and this is expected behavior. As a result, the seekdir()
test produces a spurious EINVAL when reaching end of directory. That
error is not propagated to calling process, but it may harm internal
GlusterFS processing. At least it produce a spurious error message
in brick's log.

We fix the problem by remembering the last entry offset in fd private
data. When a new posix_readdir() invocation requests that offset,
we avoid returning EINVAL.

BUG: 1129939
Change-Id: I4e67a2ea46538aae63eea663dd4aa33b16ad24c7
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8926
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijay Bellur

Posix: Brick failure detection fix for ext4 filesystem

2014-10-28T10:40:18+00:00

Issue: stat() on XFS has a check for the filesystem status but
ext4 does not.

Fix: Replacing stat() call with open, write and read  to a new file under the
"brick/.glusterfs" directory. This change will work for xfs, ext4 and other
fileystems.

Change-Id: Id03c4bc07df4ee22916a293442bd74819b051839
BUG: 1130242
Signed-off-by: Lalatendu Mohanty 
Reviewed-on: http://review.gluster.org/8213
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System