glusterfs.git/xlators/storage/posix/src, branch v3.2.3qa6

Change Copyright current year

2011-08-10T17:57:44+00:00

Change-Id: Id1f1a91cf15d933d5621a0073ddaebe02df0f159
BUG: 3348
Reviewed-on: http://review.gluster.com/198
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

LICENSE: s/GNU Affero General Public/GNU General Public/

2011-08-06T13:40:14+00:00

Change-Id: Ibf5f45431d7a55b70d7304649af652d6f25bb688
BUG: 3348
Reviewed-on: http://review.gluster.com/183
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

storage/posix: handle dictionary being NULL in a function

2011-08-01T10:38:45+00:00

Change-Id: Ib9cac6ed1635203802f089986f8acb1ce416265d
BUG: 3215
Reviewed-on: http://review.gluster.com/97
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

posix: perform readdir filling in locked region

2011-07-16T19:47:30+00:00

When two application threads share an open dir fd (DIR *) and issue
readdirs, storage/posix will receive separate readdir fops in separate
threads in parallel. This has two-fold issues

1. In the following pair of operations -

   entry = readdir(dir)
       and
   strcpy (gf_dirent->name, entry->d_name)

   @entry is a static buffer in libc which can get reused by another thread
   to get filled with a longer name. This can cause the second operation
   to overflow the buffer as the allocation was for the smaller name.

2. In the following pair of operations -

   seekdir (dir, offset)
      and
   entry = readdir(dir)

   If two threads are executing these sequence in parallel in separate
   threads, then one of them will end up reading wrong/unexpected entries.

It would be sufficient to fix 1. by using readdir_r but that still keeps
the second race open. Hence the patch moves all the set of operations to a
locked region which solves both races.

Signed-off-by: Anand Avati 

BUG: 3171 (Crash in server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3171

storage/posix: set all keys present in 'params' dict while creating an entry

2011-07-13T06:16:54+00:00

so, there is no need to do a 'setxattr()' after entry creation, which could now
fail due to ACL on server side.

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand Avati 

BUG: 3164 (set xattr keys while entry creation)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3164

storage/posix: detect race in posix_rename()

2011-07-12T09:24:57+00:00

detect a race in rename between two clients by checking for
reassigned gfid or presence of dir when not expecting.

checks not necessary for rename of files.

Signed-off-by: Anand Avati 

BUG: 2522 ([glusterfs-3.1.3qa8]: rm -rf shows invalid argument)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2522

posix-acl: implementation of POSIX ACL as a translator

2011-07-01T22:58:32+00:00

Signed-off-by: Anand Avati 

BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815

storage/posix: set ACL keys during new entry/inode creations

2011-07-01T22:58:27+00:00

honor "system.posix_acl_access" and "system.posix_acl_default" keys in
params dict to setxattr into the backend while creating new entry/inodes

Signed-off-by: Anand Avati 

BUG: 2815 (Server-enforced ACLs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2815

posix: fix GFID assignment race between mkdir and lookup

2011-06-10T10:54:06+00:00

In lookup, treat inodes which have recent ctime and no GFID as
though they are still getting created by another thread and
return ENOENT

Signed-off-by: Anand Avati 

BUG: 2994 ([glusterfs-3.2.1qa2]: untar and rm in parallel hangs untar)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2994

prevent few excessive logs

2011-04-21T14:38:33+00:00

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand Avati 

BUG: 2346 (Log message enhancements in GlusterFS - phase 1)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346