glusterfs.git/xlators/storage/posix/src/posix.c, branch v3.4.3beta2

Revert "core: fix errno for non-existent GFID"

2013-12-24T11:31:53+00:00

This reverts commit 837422858c2e4ab447879a4141361fd382645406

Change-Id: I0909f26ce088454bb14b3694b489c672286a4ae6
Reviewed-on: http://review.gluster.org/6575
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

posix: if brick-uid or brick-gid is not specified, do not set

2013-12-17T07:15:24+00:00

Current code would set owner uid/gid explicitly to 0/0 on start
even if none was specified. Fix it.

Change-Id: I72dec9e79c51bd1eb3af5334c42b7c23b01d0258
BUG: 1040275
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6476
Tested-by: Gluster Build System 
Tested-by: Lukáš Bezdička 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6519
Reviewed-by: Lukáš Bezdička

core: fix errno for non-existent GFID

2013-11-26T19:49:05+00:00

When clients refer to a GFID which does not exist, the errno to
be returned in ESTALE (and not ENOENT). Even though ENOENT might
look "proper" most of the time, as the application eventually expects
ENOENT even if a parent directory does not exist, not returning
ESTALE results in resolvers (FUSE and GFAPI) to not retry resolution
in uncached mode. This can result in spurious ENOENTs during
concurrent path modification operations.

Change-Id: I7a06ea6d6a191739f2e9c6e333a1969615e05936
BUG: 1032894
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6322
Tested-by: Gluster Build System

dht,posix: support for case discovery

2013-06-08T21:51:22+00:00

This is support for discovering a filename in a given directory
which has a case insensitive match of a given name. It is implemented
as a virtual extended attribute on the directory where the required
filename is specified in the key.

E.g:

  sh# getfattr -e "text" -n user.glusterfs.get_real_filename:FiLe-B /mnt/samba/patchy
  getfattr: Removing leading '/' from absolute path names
  # file: mnt/samba/patchy
  user.glusterfs.get_real_filename:FiLe-B="file-b"

In reality, there can be multiple "answers" as the backend filesystem is
case sensitive and there can be multiple files which can strcasecamp()
successfully. In this case we pick the first matched file from the first
responding server.

If a matching file does not exist, we return ENOENT (and NOT ENODATA).
This way the caller can differentiate between "unsupported" glusterfs
API and file not existing.

This API is used by Samba VFS to perform efficient discovery of the real
filename without doing a full scan at the Samba level.

Change-Id: I53054c4067cba69e585fd0bbce004495bc6e39e8
BUG: 953694
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5163
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

posix: fix dangerous "sharing" of fd in readdir between two requests

2013-05-07T18:54:33+00:00

posix_fill_readdir() is a multi-step function which performs many
readdir() calls, and expects the directory cursor to have not
"seeked away" elsewhere between two successive iterations. Usually
this is not a problem as each opendir() from an application has its
own backend fd, and there is nobody else to "seek away" the directory
cursor. However in case of NFS's use of anonymous fd, the same fd_t
is shared between all NFS readdir requests, and two readdir loops can
be executing in parallel on the same dir dragging away the cursor in
a chaotic manner.

The fix in this patch is to lock on the fd around the loop. Another
approach could be to reimplement posix_fill_readdir() with a single
getdents() call, but that's for another day.

Change-Id: Ia42e9c7fbcde43af4c0d08c20cc0f7419b98bd3f
BUG: 948086
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/4774
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Reviewed-on: http://review.gluster.org/4963

storage/posix: honor O_SYNC and O_DSYNC sent in @flags of writev()

2013-05-07T18:02:10+00:00

Historic bug - posix_writev() has been inspecting pfd->flushwrites for
performing fsync() after write, instead of @flags for O_SYNC|O_DSYNC.

pfd->flushwrites was never set anywhere and is unused completely. This
is behavior from the time before anonymous FD where open() had @wbflags
param. This is a leftover from that cleanup.

Change-Id: Id9bfe562a60db4eb3bd0a7705bdba91f2df2f3ec
BUG: 916372
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/4738
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-on: http://review.gluster.org/4962

storage/posix: skip path construction when dentry list is empty

2013-01-26T19:37:04+00:00

This is a minor latency optimization to the readdirp path in
storage/posix. During a recursive list, we hit this codepath with
an empty list once per high-level directory to read when end of
directory is reached. Skip constructing hpath, since we don't do
anything with it in this case.

BUG: 903175
Change-Id: I98d7c65505205d55575f064b1e982700f1320cc0
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4432
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: fix descriptions of owner-uid and owner-gid

2013-01-21T18:06:34+00:00

Change-Id: I04c0dd23bc5bc34fd9d7bddb11beeecb8e7e2a49
BUG: 853842
Signed-off-by: Shireesh Anjal 
Reviewed-on: http://review.gluster.org/4398
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

core: remove all the 'inner' functions in codebase

2012-12-20T07:35:29+00:00

* move 'dict_keys_join()' from api/glfs_fops.c to libglusterfs/dict.c
  - also added an argument which is treated as a filter function if
    required, currently useful for fuse.

* now 'make CFLAGS="-std=gnu99 -pedantic" 2>&1 | grep nested' gives
  no output.

Change-Id: I4e18496fbd93ae1d3942026ef4931889cba015e8
Signed-off-by: Amar Tumballi 
BUG: 875913
Reviewed-on: http://review.gluster.org/4187
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

storage/posix: if create returns EXIST, donot set gfid/xattrs

2012-12-04T22:43:34+00:00

Change-Id: I9f2b75b10bde428d36d6516aa09c18e590d17ed9
BUG: 864801
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/4265
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati