glusterfs.git/xlators/storage/bd_map, branch v3.4.7

core: fix Ubuntu code audit (cppcheck) results

2014-05-25T10:52:01+00:00

These block inclusion in Ubuntu Main repo.

AFAICT these are false positives:

[rpc/rpc-transport/rdma/src/rdma.c:3074]: (error) Address of local auto-variable assigned to a function parameter.
[xlators/features/marker/utils/src/gsyncd.c:99]: (error) Memory leak: str
[xlators/features/marker/utils/src/gsyncd.c:354]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1176]: (error) Possible null pointer dereference: fde

The remainder are fixed with this change-set:

[api/src/glfs-fops.c:700]: (error) Possible null pointer dereference: gio
[api/src/glfs-fops.c:702]: (error) Possible null pointer dereference: frame
[xlators/cluster/afr/src/afr-inode-write.c:375]: (error) Possible null pointer dereference: frame
[xlators/cluster/afr/src/afr-self-heal-common.c:1522]: (error) Possible null pointer dereference: local
[xlators/cluster/dht/src/dht-rebalance.c:1574]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4407]: (error) Possible null pointer dereference: local
[xlators/mgmt/glusterd/src/glusterd-mountbroker.c:675]: (error) Possible null pointer dereference: cookieswitch
[xlators/mgmt/glusterd/src/glusterd-mountbroker.c:677]: (error) Possible null pointer dereference: cookieswitch
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:924]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:1008]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:248]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-store.c:1250]: (error) Possible null pointer dereference: handle
[xlators/mgmt/glusterd/src/glusterd-utils.c:4272]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:5113]: (error) Possible null pointer dereference: this
[xlators/mount/fuse/src/fuse-bridge.c:4432]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:2927]: (error) Possible null pointer dereference: state
[xlators/mount/fuse/src/fuse-bridge.c:3226]: (error) Possible null pointer dereference: state
[xlators/storage/bd_map/src/bd_map.c:1504]: (error) Possible null pointer dereference: bd_fd
[xlators/storage/bd_map/src/bd_map.c:1728]: (error) Possible null pointer dereference: n_entry
[xlators/storage/bd_map/src/bd_map.c:1741]: (error) Possible null pointer dereference: n_entry
[xlators/performance/quick-read/src/quick-read.c:585]: (error) Possible null pointer dereference: iobuf

rerunning cppcheck --force afterwards:

Test code, don't care:
[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.

False positive after fix
[xlators/cluster/stripe/src/stripe.c:4407]: (error) Possible null pointer dereference: local

Still false positive:
[xlators/features/marker/utils/src/gsyncd.c:354]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1176]: (error) Possible null pointer dereference: fde

Not built, don't care:
[xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv

Change-Id: I1fb849e9c042d3a3701cb05121d413e58e73d505
BUG: 1086460
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/7583
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

build: declare lvm_lv_from_name() if it is missing from lvm2app.h

2013-06-27T12:39:43+00:00

The bd-xlator can not be built successfully on certain Debian
distributions due to a missing declaration of lvm_lv_from_name(). This
function is available for linking, but it does not exist in the header
file.

This change adds a detection for lvm_lv_from_name() in both the library
for linking, and the declaration in the header file. If the 1st is
missing, the bd-xlator can not be built, and if only the 2nd one is
missing, we'll declare lvm_lv_from_name() ourselves. This makes it
possible to build the bd-xlator on the affected Debian distributions
too.

Change-Id: If1845f6b6d676793677ebbcc6daf9ff12f7c3fd6
BUG: 976946
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/5260
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

Use proper libtool option -avoid-version instead of bogus -avoidversion

2013-02-07T23:12:56+00:00

Change-Id: I1c9541058c7d07786539a3266ca125a6a15287d8
BUG: 859835
Signed-off-by: Anand Avati 
Original-author: Kacper Kowalik (Xarthisius) 
Signed-off-by: Kacper Kowalik (Xarthisius) 
Reviewed-on: http://review.gluster.org/3967
Tested-by: Gluster Build System

BD Backend: CLI to create a full/linked clone of a image

2012-11-29T17:40:14+00:00

A new CLI command added to support cloning/snapshotting of a LV device

Syntax is:
$ gluster bd clone :/ 

$ gluster bd snapshot :/  

BUG: 805138
Change-Id: Idc2ac14525a3998329c742bf85a06326cac8cd54
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3719
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

BD Backend: CLI commands to create/delete image

2012-11-29T17:39:53+00:00

Cli commands  added to create/delete a LV device.

The following command creates lv in a given vg.
$ gluster bd create :/ 

The following command deletes lv in a given vg.
$ gluster bd delete :/

BUG: 805138
Change-Id: Ie4e100eca14e2ee32cf2bb4dd064b17230d673bf
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3718
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

BD Backend: Rename LV

2012-11-29T17:38:42+00:00

BUG: 805138
Change-Id: I18c64435e66ede148c58d412a0639f45554209c8
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3558
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

BD Backend: Extend size of file (LV)

2012-11-29T17:38:06+00:00

Use the truncate interface to increase the size of file (LV).

FIXME: lvm2 library does not provide any interface to extend size of LV.
So lvextend binary is forked to achieve the same

BUG: 805138
Change-Id: If4c0bd112364437b89e091b7f53764b8e6e01a28
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3557
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

BD Backend: Full clone and linked clone

2012-11-29T17:37:44+00:00

FIXME: There is no lvm2 api to create a LV snapshot. This patch forks
lvcreate binary to achieve the same.

BUG: 805138
Change-Id: Icdbead16f797162fe6a31a672b619ce6a0391235
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3556
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

BD Backend: Unlink a file (LV)

2012-11-29T17:37:26+00:00

BUG: 805138
Change-Id: I53d8a4bc09cbd9766ba937887cadd7ac475017ba
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3555
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

BD Backend: Create a new file (LV)

2012-11-29T17:36:56+00:00

Add support to create a new file (LV) under a directory (VG). By
default created LV is of one logical extent size.

Also setattr/fsetattr interfaces added as part of this patch.

BUG: 805138
Change-Id: I51752b707b3766ab277d623ce574537346f376c9
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3554
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur