glusterfs.git/xlators/storage/bd/src, branch v3.7.17

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

Avoid conflict between contrib/uuid and system uuid

2015-04-04T17:48:35+00:00

glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.

Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.

A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.

BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

bd: coverity fixes, removing logically dead code and correcting checks

2015-03-30T07:42:49+00:00

Coverity CIDs:
    1128910
    1128911
    1128913
    1128912
    1134020

Change-Id: I2d871723fbfe43f9ff6b3beba7a99b0d81d4aff5
BUG: 789278
Signed-off-by: Nandaja Varma 
Reviewed-on: http://review.gluster.org/9588
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

bd: Fixing dereference after null check(FORWARD_NULL)

2015-03-30T07:33:49+00:00

CID: 1128907
The pointer variable 'bdatt' redirected to a goto label
when the value was NULL and in the other condition when it is not NULL
, hence the bdatt is again checked for NULL at 'reverse xattr' label.

Change-Id: I2289cbf30fde9faf97e6eebd4902953a44049f9e
BUG: 789278
Signed-off-by: arao 
Reviewed-on: http://review.gluster.org/9619
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

xlators/storage/bd : Unused value is removed.

2015-03-15T15:43:53+00:00

CID:1128926

Change-Id: I5ad1229e225a36f995245a847db1a19609a18cd8
BUG: 789278
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/9556
Tested-by: Gluster Build System 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijay Bellur

core: fix remaining *printf formation warnings on 32-bit

2014-11-26T08:26:53+00:00

This fixes a few lingering size_t problems. Of particular note are
some uses of off_t for size params in function calls.

There is no correct, _portable_ way to correctly print an off_t. The
best you can do is use a scratch int64_t/PRId64 or uint64_t/PRIu64.

Change-Id: I86f3cf4678c7dbe5cad156ae8d540a66545f000d
BUG: 1110916
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8105
Tested-by: Gluster Build System 
Reviewed-by: Harshavardhana 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijay Bellur

build: MacOSX Porting fixes

2014-04-24T21:41:48+00:00

git@forge.gluster.org:~schafdog/glusterfs-core/osx-glusterfs

Working functionality on MacOSX

 - GlusterD (management daemon)
 - GlusterCLI (management cli)
 - GlusterFS FUSE (using OSXFUSE)
 - GlusterNFS (without NLM - issues with rpc.statd)

Change-Id: I20193d3f8904388e47344e523b3787dbeab044ac
BUG: 1089172
Signed-off-by: Harshavardhana 
Signed-off-by: Dennis Schafroth 
Tested-by: Harshavardhana 
Tested-by: Dennis Schafroth 
Reviewed-on: http://review.gluster.org/7503
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

storage/bd: Fix allocations/deallocations

2014-03-09T01:02:27+00:00

Change-Id: I39c9eb083fc1c144fe6f011dd983b877fbbff0f7
BUG: 1075717
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/7230
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

bd: Check for capabilities for creating thin lv

2013-12-24T10:24:33+00:00

Check capabitlies of the volume before trying to create thin LV.

BUG: 1028672

Change-Id: I1375f6f2a7576e223fc5d7cd40315999446db86a
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/6577
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

bd: Add Zerofill FOP support

2013-11-20T22:46:16+00:00

BUG: 1028673
Change-Id: I9ba8e3e6cf2f888640b4d2a2eb934a27ff903c42
Signed-off-by: Bharata B Rao 
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/6290
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati